This is an archive of the discontinued LLVM Phabricator instance.

[unittests] Add a few tests for computeKnownBits with ranges
ClosedPublic

Authored by qcolombet on Oct 6 2020, 4:11 PM.

Details

Summary

These tests make sure that the range information is properly
understood during computeKnownBits analysis.

NFC

Diff Detail

Event Timeline

qcolombet created this revision.Oct 6 2020, 4:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 6 2020, 4:11 PM
qcolombet requested review of this revision.Oct 6 2020, 4:11 PM
RKSimon accepted this revision.Oct 7 2020, 1:08 AM

LGTM with minor query

llvm/unittests/Analysis/ValueTrackingTest.cpp
1134

Is it worth adding Known.getMinValue()/getMaxValue() checks as well?

1157

Is it worth adding Known.getMinValue()/getMaxValue() checks as well?

This revision is now accepted and ready to land.Oct 7 2020, 1:08 AM
qcolombet updated this revision to Diff 296805.Oct 7 2020, 2:58 PM
  • Add getMinValue/getMaxValue
qcolombet marked 2 inline comments as done.Oct 7 2020, 2:58 PM
This revision was landed with ongoing or failed builds.Oct 8 2020, 11:35 AM
This revision was automatically updated to reflect the committed changes.