This is an archive of the discontinued LLVM Phabricator instance.

Polly - specify address space when creating a pointer to a vector type
ClosedPublic

Authored by marksl on Oct 6 2020, 8:53 AM.

Details

Summary

Polly incorrectly dropped the address space specified for a load instruction when it vectorized the code.

Diff Detail

Event Timeline

marksl created this revision.Oct 6 2020, 8:53 AM
marksl requested review of this revision.Oct 6 2020, 8:53 AM

Thank you for the patch. Just one remark on how to improve the test case.

polly/test/ScheduleOptimizer/vec-addr-space.ll
2

Do you really need to to specify all the passes explicitly? Most should be added implicitly by dependence anyway.

marksl updated this revision to Diff 296770.Oct 7 2020, 12:23 PM

Reduced the arguments to opt

marksl added inline comments.Oct 14 2020, 7:44 AM
polly/test/ScheduleOptimizer/vec-addr-space.ll
2

I minimized the passes.

If you're happy with it, would you mind committing it? I don't have commit privileges.

Meinersbur accepted this revision.Oct 14 2020, 9:13 AM

Thanks for the patch

This revision is now accepted and ready to land.Oct 14 2020, 9:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 14 2020, 9:17 AM