This is an archive of the discontinued LLVM Phabricator instance.

[clang] Add a test for CGDebugInfo treatment of blocks
ClosedPublic

Authored by scott.linder on Oct 2 2020, 1:34 PM.

Download Raw Diff

Details

Reviewers

gbenyei
aprantl
fhahn

Commits

rG40cef5a00eb8: [clang] Add a test for CGDebugInfo treatment of blocks

Summary

There doesn't seem to be a direct test of this, and I'm planning to make future changes which will affect it.

I'm not particularly familiar with the blocks extension, so suggestions for better tests are welcome.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed

	Time	Test
	1,100 ms	linux > libarcher.parallel::parallel-nosuppression.c

Event Timeline

scott.linder created this revision.Oct 2 2020, 1:34 PM

Herald added a project: Restricted Project. · View Herald TranscriptOct 2 2020, 1:34 PM

Herald added a subscriber: cfe-commits. · View Herald Transcript

scott.linder requested review of this revision.Oct 2 2020, 1:34 PM

scott.linder edited the summary of this revision. (Show Details)Oct 2 2020, 1:36 PM

scott.linder added reviewers: gbenyei, aprantl, fhahn.

Harbormaster completed remote builds in B73833: Diff 295903.Oct 2 2020, 1:45 PM

I think that this should either hardcode a 64-bit architecture or it shouldn't test for explicit offsets.

Don't hardcode x86_64-specific offsets

Harbormaster completed remote builds in B74195: Diff 296558.Oct 6 2020, 3:52 PM

Thanks!

This revision is now accepted and ready to land.Oct 9 2020, 11:53 AM

Closed by commit rG40cef5a00eb8: [clang] Add a test for CGDebugInfo treatment of blocks (authored by scott.linder). · Explain WhyOct 9 2020, 12:09 PM

This revision was automatically updated to reflect the committed changes.

scott.linder added a commit: rG40cef5a00eb8: [clang] Add a test for CGDebugInfo treatment of blocks.

Revision Contents

Path

Size

clang/

test/

CodeGen/

debug-info-block-expr.c

9 lines

Diff 295903

clang/test/CodeGen/debug-info-block-expr.c

This file was added.

				// RUN: %clang_cc1 -fblocks -debug-info-kind=limited -emit-llvm -o - %s \| FileCheck %s
				// Verify that the desired DIExpression are generated for blocks.

				void test() {
				// CHECK: call void @llvm.dbg.declare({{.}}!DIExpression(DW_OP_plus_uconst, 8, DW_OP_deref, DW_OP_plus_uconst, 24){{.}})
				__block int i;
				// CHECK: call void @llvm.dbg.declare({{.}}!DIExpression(DW_OP_deref, DW_OP_plus_uconst, 32, DW_OP_deref, DW_OP_plus_uconst, 8, DW_OP_deref, DW_OP_plus_uconst, 24){{.}})
				^ { i = 1; }();
				}