Page MenuHomePhabricator

gbenyei (Guy Benyei)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 13 2015, 5:20 AM (370 w, 1 d)

Recent Activity

Jun 30 2022

gbenyei updated the diff for D128612: RISC-V big-endian support implementation.

Removed LLD and JIT related parts - JIT is out of my scope, and LLD will be in an additional patch.
Fixed additional remarks.

Jun 30 2022, 8:29 AM · Restricted Project, lld, Restricted Project, Restricted Project, Restricted Project
gbenyei added inline comments to D128612: RISC-V big-endian support implementation.
Jun 30 2022, 8:25 AM · Restricted Project, lld, Restricted Project, Restricted Project, Restricted Project

Jun 29 2022

gbenyei added a comment to D128612: RISC-V big-endian support implementation.

lld/ELF change should be dropped from this change. Don't use config->endianness.
I feel sad that for little-endian users who don't use big-endian, every write now is slightly slower due to a check ;-)

Hi, I'm not sure I get it. How will we have a fully functional toolchain, if I don't implement the lld/ELF part?
In LLVM, unlike in GCC, target related decisions happen in runtime. I think it's a high level design decision. While I can understand the pain of LE developers getting a slightly slower linker due to endianness checking, I sure will feel the pain of a BE developer not having a linker...

Please explain why I shouldn't use config->endianness?

See PPC64.cpp. See D96188 how I added aarch64_be support. A set of representative tests should be picked with be tests.
If llvm-project consensus is that we will add big-endian support, I can handle lld/ELF part. I am mostly concerned with this scenarios that some RISC-V folks click LGTM, and the change lands with no test in some areas, or the code somewhat breaks local convention.

Many of the changes in this patch probably should be split. llvm-objcopy and JIT changes definitely needs appropriate tests and the suitable domain reviewers.

Jun 29 2022, 9:38 PM · Restricted Project, lld, Restricted Project, Restricted Project, Restricted Project
gbenyei added a comment to D128612: RISC-V big-endian support implementation.

lld/ELF change should be dropped from this change. Don't use config->endianness.
I feel sad that for little-endian users who don't use big-endian, every write now is slightly slower due to a check ;-)

Jun 29 2022, 2:21 AM · Restricted Project, lld, Restricted Project, Restricted Project, Restricted Project
gbenyei added a comment to D128612: RISC-V big-endian support implementation.

Objcopy aspects look good, thanks.

Jun 29 2022, 2:15 AM · Restricted Project, lld, Restricted Project, Restricted Project, Restricted Project

Jun 28 2022

gbenyei updated the diff for D128612: RISC-V big-endian support implementation.
Jun 28 2022, 5:43 AM · Restricted Project, lld, Restricted Project, Restricted Project, Restricted Project

Jun 27 2022

gbenyei updated the diff for D128612: RISC-V big-endian support implementation.

Thanks, Craig. Updated the patch with your remarks.

Jun 27 2022, 6:25 AM · Restricted Project, lld, Restricted Project, Restricted Project, Restricted Project

Jun 26 2022

gbenyei requested review of D128612: RISC-V big-endian support implementation.
Jun 26 2022, 8:20 AM · Restricted Project, lld, Restricted Project, Restricted Project, Restricted Project

Jul 13 2015

gbenyei added a comment to D10893: [X86][AVX512VL-BW] Add more intrinsics support.

IdentifierInfo change LGTM, based on the discussion here:

Jul 13 2015, 5:32 AM