Page MenuHomePhabricator

[MLIR][SPIRV] Extend _reference_of to support SpecConstantCompositeOp.
ClosedPublic

Authored by ergawy on Oct 2 2020, 5:34 AM.

Details

Summary

Adds support for SPIR-V composite speciailization constants to spv._reference_of.

Diff Detail

Event Timeline

ergawy created this revision.Oct 2 2020, 5:34 AM
ergawy requested review of this revision.Oct 2 2020, 5:34 AM
ergawy updated this revision to Diff 295806.Oct 2 2020, 5:44 AM
  • Rebase (testing how stacked reviews work).
ergawy added a comment.Oct 2 2020, 5:49 AM

Looks like I misunderstood how stacked reviews work and that's why the CI fails. Is there a workflow that you can share for creating such stacks of reviews?

ergawy updated this revision to Diff 296107.Oct 5 2020, 1:17 AM
  • Merge remote-tracking branch 'origin/master' into mlir/spirv/support_op_spec_constant_composite
antiagainst accepted this revision.Oct 5 2020, 1:37 PM

Thanks!

This revision is now accepted and ready to land.Oct 5 2020, 1:37 PM