Page MenuHomePhabricator

[mlir] Fix call op conversion in bare-ptr calling convention
ClosedPublic

Authored by dcaballe on Oct 1 2020, 4:17 PM.

Details

Summary

We hit an llvm_unreachable related to unranked memrefs for call ops
with scalar types. Removing the llvm_unreachable since the conversion
should gracefully bail out in the presence of unranked memrefs. Adding
tests to verify that.

Diff Detail

Event Timeline

dcaballe created this revision.Oct 1 2020, 4:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 1 2020, 4:17 PM
dcaballe requested review of this revision.Oct 1 2020, 4:17 PM
ftynse accepted this revision.Oct 2 2020, 1:17 AM
This revision is now accepted and ready to land.Oct 2 2020, 1:17 AM