This is an archive of the discontinued LLVM Phabricator instance.

Differential D88646

[LLD] Add baseline test for TLS alignment. NFC.
ClosedPublic

Authored by luqmana on Oct 1 2020, 3:06 AM.

Details

Reviewers
ruiu
rnk
Commits
rG6b7738e204b4: [LLD] Add baseline test for TLS alignment. NFC.

Diff Detail

Event Timeline

luqmana created this revision.Oct 1 2020, 3:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 1 2020, 3:06 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
luqmana requested review of this revision.Oct 1 2020, 3:06 AM
luqmana updated this revision to Diff 295511.

Use the right flag.

luqmana added a parent revision: D88635: [llvm-readobj] Add --coff-tls-directory flag to print TLS Directory & test..Oct 1 2020, 3:08 AM
Harbormaster completed remote builds in B73631: Diff 295511.Oct 1 2020, 3:08 AM
luqmana added a child revision: D88637: [LLD] Set alignment as part of Characteristics in TLS table..Oct 1 2020, 3:10 AM
Harbormaster completed remote builds in B73630: Diff 295510.Oct 1 2020, 3:12 AM
luqmana updated this revision to Diff 295520.Oct 1 2020, 3:37 AM

Update.

Harbormaster completed remote builds in B73636: Diff 295520.Oct 1 2020, 3:51 AM
luqmana updated this revision to Diff 296581.Oct 6 2020, 7:50 PM

Add 32bit test as well.

Harbormaster completed remote builds in B74214: Diff 296581.Oct 6 2020, 8:04 PM
luqmana added reviewers: rnk, grimar.Oct 6 2020, 8:26 PM
grimar added a comment.Oct 7 2020, 1:15 AM

I am not familar with LLD/COFF, sorry.

grimar removed a reviewer: grimar.Oct 7 2020, 1:15 AM
rnk accepted this revision.Oct 13 2020, 12:43 PM

I would probably construct these tests with an assembly file, but it's fine this way too. Looks good.

This revision is now accepted and ready to land.Oct 13 2020, 12:43 PM
Closed by commit rG6b7738e204b4: [LLD] Add baseline test for TLS alignment. NFC. (authored by luqmana). · Explain WhyOct 13 2020, 8:56 PM
This revision was automatically updated to reflect the committed changes.
luqmana added a commit: rG6b7738e204b4: [LLD] Add baseline test for TLS alignment. NFC..

Revision Contents

PathSize
lld/
test/
COFF/
2 lines

Diff 295511

lld/test/COFF/tls-alignment.ll

; This test is to make sure that the necessary alignment for thread locals ; This test is to make sure that the necessary alignment for thread locals
; gets reflected in the TLS Directory of the generated executable. ; gets reflected in the TLS Directory of the generated executable.
; ;
; aligned_thread_local specifies 'align 32' and so the generated ; aligned_thread_local specifies 'align 32' and so the generated
; exe should reflect that with a value of IMAGE_SCN_ALIGN_32BYTES ; exe should reflect that with a value of IMAGE_SCN_ALIGN_32BYTES
; in the Characteristics field of the IMAGE_TLS_DIRECTORY ; in the Characteristics field of the IMAGE_TLS_DIRECTORY
; RUN: llc -filetype=obj %s -o %t.obj ; RUN: llc -filetype=obj %s -o %t.obj
; RUN: lld-link %t.obj -entry:main -nodefaultlib -out:%t.exe ; RUN: lld-link %t.obj -entry:main -nodefaultlib -out:%t.exe
; RUN: llvm-readobj --coff-tls-table %t.exe | FileCheck %s ; RUN: llvm-readobj --coff-tls-directory %t.exe | FileCheck %s
; CHECK: Characteristics [ (0x0) ; CHECK: Characteristics [ (0x0)
target datalayout = "e-m:w-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128" target datalayout = "e-m:w-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-pc-windows-msvc" target triple = "x86_64-pc-windows-msvc"
%IMAGE_TLS_DIRECTORY = type { %IMAGE_TLS_DIRECTORY = type {
i64, ; StartAddressOfRawData i64, ; StartAddressOfRawData
Show All 29 Lines