Page MenuHomePhabricator

luqmana (Luqman Aden)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 14 2013, 2:35 AM (400 w, 5 d)

Recent Activity

Oct 27 2020

luqmana committed rG4c0a01692787: Rename EHPersonality::MSVC_Win64SEH to EHPersonality::MSVC_TableSEH. NFC. (authored by luqmana).
Rename EHPersonality::MSVC_Win64SEH to EHPersonality::MSVC_TableSEH. NFC.
Oct 27 2020, 11:42 PM
luqmana closed D90117: Rename EHPersonality::MSVC_Win64SEH to EHPersonality::MSVC_TableSEH. NFC..
Oct 27 2020, 11:42 PM · Restricted Project
luqmana added a comment to D90117: Rename EHPersonality::MSVC_Win64SEH to EHPersonality::MSVC_TableSEH. NFC..

I also think TableSEH is a bit clearer. And yea, I'll try to clean up other similar Win64 cases as I get around.

Oct 27 2020, 11:41 PM · Restricted Project

Oct 25 2020

luqmana requested review of D90117: Rename EHPersonality::MSVC_Win64SEH to EHPersonality::MSVC_TableSEH. NFC..
Oct 25 2020, 6:50 AM · Restricted Project

Oct 19 2020

luqmana added a comment to D89622: [COFF][ARM] Fix CodeView for Windows on 32bit ARM targets..

Thanks for doing this!

Oct 19 2020, 10:17 PM · Restricted Project
luqmana committed rG51892a42dac5: [COFF][ARM] Fix CodeView for Windows on 32bit ARM targets. (authored by luqmana).
[COFF][ARM] Fix CodeView for Windows on 32bit ARM targets.
Oct 19 2020, 10:17 PM
luqmana closed D89622: [COFF][ARM] Fix CodeView for Windows on 32bit ARM targets..
Oct 19 2020, 10:17 PM · Restricted Project
luqmana updated the diff for D89622: [COFF][ARM] Fix CodeView for Windows on 32bit ARM targets..

Nit: consolidate getRegisterNames calls.

Oct 19 2020, 9:26 PM · Restricted Project
luqmana added inline comments to D89622: [COFF][ARM] Fix CodeView for Windows on 32bit ARM targets..
Oct 19 2020, 6:50 PM · Restricted Project
luqmana updated the diff for D89622: [COFF][ARM] Fix CodeView for Windows on 32bit ARM targets..

Address review comments.

Oct 19 2020, 6:50 PM · Restricted Project

Oct 17 2020

luqmana requested review of D89622: [COFF][ARM] Fix CodeView for Windows on 32bit ARM targets..
Oct 17 2020, 5:00 AM · Restricted Project

Oct 15 2020

luqmana committed rG6a73d6564a3c: [LLD] Set alignment as part of Characteristics in TLS table. (authored by luqmana).
[LLD] Set alignment as part of Characteristics in TLS table.
Oct 15 2020, 12:27 AM
luqmana added a reverting change for rG8b70d527d7ec: [LLD] Set alignment as part of Characteristics in TLS table.: rGf87c98def86b: Revert "[LLD] Set alignment as part of Characteristics in TLS table.".
Oct 15 2020, 12:27 AM
luqmana added a reverting change for rG0778cad9f325: Fix style warnings.: rGf87c98def86b: Revert "[LLD] Set alignment as part of Characteristics in TLS table.".
Oct 15 2020, 12:27 AM
luqmana added a reverting change for rGf80950a8bb98: Update tests.: rGf87c98def86b: Revert "[LLD] Set alignment as part of Characteristics in TLS table.".
Oct 15 2020, 12:27 AM
luqmana added a reverting change for rG51fbc1bef657: Mask out existing alignment bits.: rGf87c98def86b: Revert "[LLD] Set alignment as part of Characteristics in TLS table.".
Oct 15 2020, 12:27 AM
luqmana added a reverting change for rG7fe13af67667: Nit: Use early return to reduce indentation.: rGf87c98def86b: Revert "[LLD] Set alignment as part of Characteristics in TLS table.".
Oct 15 2020, 12:27 AM
luqmana added a reverting change for D88637: [LLD] Set alignment as part of Characteristics in TLS table.: rGf87c98def86b: Revert "[LLD] Set alignment as part of Characteristics in TLS table.".
Oct 15 2020, 12:27 AM · Restricted Project
luqmana added a reverting change for rG32a4ad3b6ce6: [LLD] Set alignment as part of Characteristics in TLS table.: rGf87c98def86b: Revert "[LLD] Set alignment as part of Characteristics in TLS table.".
Oct 15 2020, 12:26 AM
luqmana committed rGf87c98def86b: Revert "[LLD] Set alignment as part of Characteristics in TLS table." (authored by luqmana).
Revert "[LLD] Set alignment as part of Characteristics in TLS table."
Oct 15 2020, 12:26 AM
luqmana updated the diff for D88637: [LLD] Set alignment as part of Characteristics in TLS table..

Accidentally messed up the last diff there. Update revision with final code change that was committed for visibility.

Oct 15 2020, 12:26 AM · Restricted Project

Oct 14 2020

luqmana committed rG32a4ad3b6ce6: [LLD] Set alignment as part of Characteristics in TLS table. (authored by luqmana).
[LLD] Set alignment as part of Characteristics in TLS table.
Oct 14 2020, 7:41 PM
luqmana committed rG7fe13af67667: Nit: Use early return to reduce indentation. (authored by luqmana).
Nit: Use early return to reduce indentation.
Oct 14 2020, 7:37 PM
luqmana committed rG51fbc1bef657: Mask out existing alignment bits. (authored by luqmana).
Mask out existing alignment bits.
Oct 14 2020, 7:37 PM
luqmana committed rGf80950a8bb98: Update tests. (authored by luqmana).
Update tests.
Oct 14 2020, 7:37 PM
luqmana committed rG0778cad9f325: Fix style warnings. (authored by luqmana).
Fix style warnings.
Oct 14 2020, 7:37 PM
luqmana committed rG8b70d527d7ec: [LLD] Set alignment as part of Characteristics in TLS table. (authored by luqmana).
[LLD] Set alignment as part of Characteristics in TLS table.
Oct 14 2020, 7:37 PM
luqmana closed D88637: [LLD] Set alignment as part of Characteristics in TLS table..
Oct 14 2020, 7:37 PM · Restricted Project
luqmana updated the diff for D88637: [LLD] Set alignment as part of Characteristics in TLS table..

Address nit: Use early return to reduce indentation.

Oct 14 2020, 7:33 PM · Restricted Project
luqmana committed rGdc128e5968cc: [test][lld] Mark TLS tests as REQUIRES: x86. (authored by luqmana).
[test][lld] Mark TLS tests as REQUIRES: x86.
Oct 14 2020, 12:33 AM

Oct 13 2020

luqmana updated the diff for D88637: [LLD] Set alignment as part of Characteristics in TLS table..

Mask out existing alignment bits.

Oct 13 2020, 11:01 PM · Restricted Project
luqmana committed rG6b7738e204b4: [LLD] Add baseline test for TLS alignment. NFC. (authored by luqmana).
[LLD] Add baseline test for TLS alignment. NFC.
Oct 13 2020, 8:56 PM
luqmana closed D88646: [LLD] Add baseline test for TLS alignment. NFC..
Oct 13 2020, 8:56 PM · Restricted Project

Oct 12 2020

luqmana added a comment to D88637: [LLD] Set alignment as part of Characteristics in TLS table..

Ping?

Oct 12 2020, 5:23 PM · Restricted Project

Oct 8 2020

luqmana committed rG568035ac3955: [llvm-readobj] Add --coff-tls-directory flag to print TLS Directory & test. (authored by luqmana).
[llvm-readobj] Add --coff-tls-directory flag to print TLS Directory & test.
Oct 8 2020, 1:57 AM
luqmana closed D88635: [llvm-readobj] Add --coff-tls-directory flag to print TLS Directory & test..
Oct 8 2020, 1:57 AM · Restricted Project
luqmana added inline comments to D88635: [llvm-readobj] Add --coff-tls-directory flag to print TLS Directory & test..
Oct 8 2020, 1:45 AM · Restricted Project
luqmana updated the diff for D88635: [llvm-readobj] Add --coff-tls-directory flag to print TLS Directory & test..
Use same check statements for empty TLS directory tests and fix nits.
Oct 8 2020, 1:44 AM · Restricted Project
luqmana added inline comments to D88635: [llvm-readobj] Add --coff-tls-directory flag to print TLS Directory & test..
Oct 8 2020, 1:19 AM · Restricted Project
luqmana updated the diff for D88635: [llvm-readobj] Add --coff-tls-directory flag to print TLS Directory & test..
Fix typos and put related test cases together.
Oct 8 2020, 1:15 AM · Restricted Project
luqmana updated the diff for D88635: [llvm-readobj] Add --coff-tls-directory flag to print TLS Directory & test..

Address review comments.

Oct 8 2020, 1:07 AM · Restricted Project

Oct 7 2020

luqmana removed a reviewer for D88637: [LLD] Set alignment as part of Characteristics in TLS table.: grimar.
Oct 7 2020, 2:38 AM · Restricted Project
luqmana added a comment to D88635: [llvm-readobj] Add --coff-tls-directory flag to print TLS Directory & test..

I think you can:

  1. Merge 7 test cases you have into one (use yaml2obj's --docnum option, see examples in llvm-readobj\ELF\)
  2. Perhaps you can reuse YAMLs with use of yaml2obj's macros feature (-D<macro>=<value>). See llvm-readobj\ELF\reloc-addends.test and many other tests.
  3. It feels that you should be able to reduce YAML descriptions, e.g. remove excessive sections? (so, try to keep parts that are related/needed only)
Oct 7 2020, 2:37 AM · Restricted Project
luqmana updated the diff for D88635: [llvm-readobj] Add --coff-tls-directory flag to print TLS Directory & test..
  • Consolidate and simplify tests.
Oct 7 2020, 2:33 AM · Restricted Project

Oct 6 2020

luqmana added reviewers for D88637: [LLD] Set alignment as part of Characteristics in TLS table.: rnk, grimar.
Oct 6 2020, 8:26 PM · Restricted Project
luqmana added reviewers for D88646: [LLD] Add baseline test for TLS alignment. NFC.: rnk, grimar.
Oct 6 2020, 8:26 PM · Restricted Project
luqmana updated the diff for D88637: [LLD] Set alignment as part of Characteristics in TLS table..

Update tests.

Oct 6 2020, 7:51 PM · Restricted Project
luqmana updated the diff for D88646: [LLD] Add baseline test for TLS alignment. NFC..

Add 32bit test as well.

Oct 6 2020, 7:50 PM · Restricted Project
luqmana updated the diff for D88635: [llvm-readobj] Add --coff-tls-directory flag to print TLS Directory & test..

Add more tests and use YAML instead of precompiled binary.

Oct 6 2020, 6:29 PM · Restricted Project
luqmana resigned from D43544: [Transforms][SROA] Fixed assertion crash (PR30416).
Oct 6 2020, 12:14 AM
luqmana resigned from D34285: [SROA] Be smarter when copying metadata to retyped loads.
Oct 6 2020, 12:13 AM

Oct 1 2020

luqmana updated the diff for D88637: [LLD] Set alignment as part of Characteristics in TLS table..
Fix style warnings.
Oct 1 2020, 6:45 AM · Restricted Project
luqmana updated the diff for D88637: [LLD] Set alignment as part of Characteristics in TLS table..

Update.

Oct 1 2020, 3:38 AM · Restricted Project
luqmana updated the diff for D88646: [LLD] Add baseline test for TLS alignment. NFC..

Update.

Oct 1 2020, 3:37 AM · Restricted Project
luqmana updated the diff for D88635: [llvm-readobj] Add --coff-tls-directory flag to print TLS Directory & test..

Update.

Oct 1 2020, 3:36 AM · Restricted Project
luqmana updated the summary of D88637: [LLD] Set alignment as part of Characteristics in TLS table..
Oct 1 2020, 3:13 AM · Restricted Project
luqmana updated the diff for D88646: [LLD] Add baseline test for TLS alignment. NFC..

Use the right flag.

Oct 1 2020, 3:07 AM · Restricted Project
luqmana requested review of D88646: [LLD] Add baseline test for TLS alignment. NFC..
Oct 1 2020, 3:06 AM · Restricted Project
luqmana added reviewers for D88635: [llvm-readobj] Add --coff-tls-directory flag to print TLS Directory & test.: ruiu, rnk.
Oct 1 2020, 2:52 AM · Restricted Project
luqmana added a comment to D88635: [llvm-readobj] Add --coff-tls-directory flag to print TLS Directory & test..

Thanks for the patch. It looks to me like this patch is intended to add a new option to llvm-readobj. This should be tested in the llvm-readobj tests, and not in the LLD tests. If you want a new test for LLD, you'll probably want a separate patch for using this new option. You'll want to use a different method to create your input for llvm-readobj, since the LLVM tools should be testable without it. This might require you to use something like yaml2obj to create your test input (I'm assuming you need a "linked" image, rather than a relocatable COFF object - I'm not particularly familiar with COFF).

You also need to update the documentation located at llvm\docs\CommandGuide\llvm-readobj.rst with the new option.

I can't comment on the functional logic of the patch, due to lack of expertise with COFF. Please make sure to add some reviewers who have touched/reviewed the COFF dumping code recently.

Oct 1 2020, 2:44 AM · Restricted Project
luqmana updated the diff for D88635: [llvm-readobj] Add --coff-tls-directory flag to print TLS Directory & test..

Add newline at the end of new test.

Oct 1 2020, 2:29 AM · Restricted Project
luqmana retitled D88635: [llvm-readobj] Add --coff-tls-directory flag to print TLS Directory & test. from [llvm-readobj][LLD] Add --coff-tls-table flag to print TLS Table & test. to [llvm-readobj] Add --coff-tls-directory flag to print TLS Directory & test..
Oct 1 2020, 2:27 AM · Restricted Project
luqmana updated the diff for D88635: [llvm-readobj] Add --coff-tls-directory flag to print TLS Directory & test..

Add llvm-readobj test and address comments.

Oct 1 2020, 2:23 AM · Restricted Project
luqmana updated the summary of D88637: [LLD] Set alignment as part of Characteristics in TLS table..
Oct 1 2020, 1:28 AM · Restricted Project
luqmana requested review of D88637: [LLD] Set alignment as part of Characteristics in TLS table..
Oct 1 2020, 1:17 AM · Restricted Project
luqmana updated the summary of D88635: [llvm-readobj] Add --coff-tls-directory flag to print TLS Directory & test..
Oct 1 2020, 1:04 AM · Restricted Project
luqmana requested review of D88635: [llvm-readobj] Add --coff-tls-directory flag to print TLS Directory & test..
Oct 1 2020, 1:02 AM · Restricted Project

Apr 20 2019

luqmana committed rG2993661cc0e5: [CorrelatedValuePropagation] Mark subs that we know not to wrap with nuw/nsw. (authored by luqmana).
[CorrelatedValuePropagation] Mark subs that we know not to wrap with nuw/nsw.
Apr 20 2019, 6:13 AM
luqmana committed rL358816: [CorrelatedValuePropagation] Mark subs that we know not to wrap with nuw/nsw..
[CorrelatedValuePropagation] Mark subs that we know not to wrap with nuw/nsw.
Apr 20 2019, 6:12 AM
luqmana closed D60036: [CorrelatedValuePropagation] Mark subs that we know not to wrap with nuw/nsw..
Apr 20 2019, 6:12 AM · Restricted Project
luqmana updated the diff for D60036: [CorrelatedValuePropagation] Mark subs that we know not to wrap with nuw/nsw..

Rebase over committed baseline tests.

Apr 20 2019, 3:40 AM · Restricted Project

Apr 19 2019

luqmana added a comment to D60036: [CorrelatedValuePropagation] Mark subs that we know not to wrap with nuw/nsw..

We should probably give reenabling the option by default another try (in a separate revision), at least I can't seem to reproduce the issue in PR31181 anymore.

Apr 19 2019, 11:18 PM · Restricted Project
luqmana updated the diff for D60036: [CorrelatedValuePropagation] Mark subs that we know not to wrap with nuw/nsw..

Rename option and method to be more general.

Apr 19 2019, 11:12 PM · Restricted Project
luqmana added inline comments to D60036: [CorrelatedValuePropagation] Mark subs that we know not to wrap with nuw/nsw..
Apr 19 2019, 11:12 PM · Restricted Project

Apr 4 2019

luqmana added a comment to D60036: [CorrelatedValuePropagation] Mark subs that we know not to wrap with nuw/nsw..

Ping?

Apr 4 2019, 12:13 AM · Restricted Project
luqmana committed rG8911c5be46b9: [InstCombine] Combine no-wrap sub and icmp w/ constant. (authored by luqmana).
[InstCombine] Combine no-wrap sub and icmp w/ constant.
Apr 4 2019, 12:10 AM
luqmana committed rL357674: [InstCombine] Combine no-wrap sub and icmp w/ constant..
[InstCombine] Combine no-wrap sub and icmp w/ constant.
Apr 4 2019, 12:10 AM
luqmana closed D59916: [InstCombine] Combine no-wrap sub and icmp w/ constant..
Apr 4 2019, 12:10 AM · Restricted Project

Mar 31 2019

luqmana updated the diff for D59916: [InstCombine] Combine no-wrap sub and icmp w/ constant..

Rebased on committed tests.

Mar 31 2019, 2:03 AM · Restricted Project
luqmana committed rG7c67dbdc65fe: [NFC][InstCombine] Add tests for combining icmp of no-wrap sub w/ constant. (authored by luqmana).
[NFC][InstCombine] Add tests for combining icmp of no-wrap sub w/ constant.
Mar 31 2019, 1:58 AM
luqmana committed rL357360: [NFC][InstCombine] Add tests for combining icmp of no-wrap sub w/ constant..
[NFC][InstCombine] Add tests for combining icmp of no-wrap sub w/ constant.
Mar 31 2019, 1:57 AM
luqmana added inline comments to D59916: [InstCombine] Combine no-wrap sub and icmp w/ constant..
Mar 31 2019, 1:08 AM · Restricted Project
luqmana updated the diff for D59916: [InstCombine] Combine no-wrap sub and icmp w/ constant..

Give tests more descriptive names and add one more negative test.

Mar 31 2019, 1:08 AM · Restricted Project

Mar 30 2019

luqmana added a comment to D59916: [InstCombine] Combine no-wrap sub and icmp w/ constant..

Can you please split off the InstCombine change into a separate revision?

Mar 30 2019, 2:42 PM · Restricted Project
luqmana updated the diff for D59916: [InstCombine] Combine no-wrap sub and icmp w/ constant..

Split off CorrelatedValuePropagation changes to new revision: D60036

Mar 30 2019, 2:42 PM · Restricted Project
luqmana created D60036: [CorrelatedValuePropagation] Mark subs that we know not to wrap with nuw/nsw..
Mar 30 2019, 2:39 PM · Restricted Project

Mar 27 2019

luqmana created D59916: [InstCombine] Combine no-wrap sub and icmp w/ constant..
Mar 27 2019, 10:54 PM · Restricted Project

Mar 22 2017

luqmana committed rL298540: Preserve nonnull metadata on Loads through SROA & mem2reg..
Preserve nonnull metadata on Loads through SROA & mem2reg.
Mar 22 2017, 12:29 PM
luqmana closed D27114: Preserve nonnull metadata on Loads through SROA & mem2reg. by committing rL298540: Preserve nonnull metadata on Loads through SROA & mem2reg..
Mar 22 2017, 12:28 PM
luqmana added a comment to D27114: Preserve nonnull metadata on Loads through SROA & mem2reg..

LGTM.

Luqman, thanks for putting up with the long delay in reviewing this.

Do you have commit access, or should I commit this for you?

Mar 22 2017, 11:33 AM

Mar 21 2017

luqmana updated the diff for D27114: Preserve nonnull metadata on Loads through SROA & mem2reg..

I added another test for all the relevant codepaths in PromoteMemoryToRegister.
I also addressed one case I missed earlier: when the alloca in question has
multiple stores but all within the same basic block.

Mar 21 2017, 9:57 PM

Mar 4 2017

luqmana added a comment to D27114: Preserve nonnull metadata on Loads through SROA & mem2reg..

Ping?

Mar 4 2017, 8:08 PM

Feb 28 2017

luqmana updated the diff for D27114: Preserve nonnull metadata on Loads through SROA & mem2reg..

Use copyMetadata method instead of manually copying metadata.

Feb 28 2017, 7:57 AM

Feb 24 2017

luqmana added a comment to D27114: Preserve nonnull metadata on Loads through SROA & mem2reg..

Ping

Feb 24 2017, 3:19 PM

Feb 17 2017

luqmana added a comment to D27114: Preserve nonnull metadata on Loads through SROA & mem2reg..

Ping?

Feb 17 2017, 2:31 PM

Feb 9 2017

luqmana updated the diff for D27114: Preserve nonnull metadata on Loads through SROA & mem2reg..

Don't add assume if the value is already known to be nonnull.

Feb 9 2017, 8:02 PM

Feb 8 2017

luqmana added a comment to D27114: Preserve nonnull metadata on Loads through SROA & mem2reg..

Ping

Feb 8 2017, 11:37 AM

Jan 26 2017

luqmana added a comment to D27114: Preserve nonnull metadata on Loads through SROA & mem2reg..

Ping

Jan 26 2017, 7:56 PM

Jan 18 2017

luqmana added a comment to D27114: Preserve nonnull metadata on Loads through SROA & mem2reg..

Ping

Jan 18 2017, 1:15 PM

Jan 11 2017

luqmana added a comment to D27114: Preserve nonnull metadata on Loads through SROA & mem2reg..

So at least running the test suite I didn't come across any performance regressions. Could we land this and observe the buildbots or something for any regressions and back out as necessary?

Jan 11 2017, 10:54 AM