This is an archive of the discontinued LLVM Phabricator instance.

[llvm-readobj][test] - Stop using few precompiled binaries in mips-got.test
ClosedPublic

Authored by grimar on Sep 29 2020, 7:19 AM.

Details

Summary

This removes 4 input files (one source file and 3 precompiled binaries) from
mips-got.test (now YAMLs are used instead) and also makes the testing of
the GNU output a bit stricter (--strict-whitespace --match-full-lines).

Diff Detail

Event Timeline

grimar created this revision.Sep 29 2020, 7:19 AM
grimar requested review of this revision.Sep 29 2020, 7:19 AM
grimar retitled this revision from [llvm-readobj][[test] - Stop using a few precompiled binaries in mips-got.test to [llvm-readobj][test] - Stop using few precompiled binaries in mips-got.test.Sep 29 2020, 7:24 AM
grimar added a reviewer: atanasyan.
grimar removed a subscriber: atanasyan.
This revision is now accepted and ready to land.Sep 29 2020, 8:03 AM
jhenderson added inline comments.Sep 30 2020, 12:44 AM
llvm/test/tools/llvm-readobj/ELF/mips-got.test
9–11

Maybe for consistency the prefix should be BASIC-LLVM. Same below.

grimar updated this revision to Diff 295196.Sep 30 2020, 1:02 AM
grimar marked an inline comment as done.
  • Addressed review comment: use *-LLVM suffix.
grimar added inline comments.Sep 30 2020, 1:25 AM
llvm/test/tools/llvm-readobj/ELF/mips-got.test
9–11

Fixed. Does the rest LG to you?

jhenderson accepted this revision.Sep 30 2020, 1:30 AM

Looks good (I haven't looked much in detail at the core of the test logic mind you).