Page MenuHomePhabricator

[LLVM-C] Turn a ShuffleVector Constant Into a Getter.
ClosedPublic

Authored by CodaFi on Sep 26 2020, 3:39 PM.

Details

Summary

It is not a good idea to expose raw constants in the LLVM C API. Replace this with an explicit getter.

Diff Detail

Event Timeline

CodaFi created this revision.Sep 26 2020, 3:39 PM
Herald added a project: Restricted Project. · View Herald Transcript
CodaFi requested review of this revision.Sep 26 2020, 3:39 PM
CodaFi updated this revision to Diff 294520.
CodaFi updated this revision to Diff 294521.Sep 26 2020, 3:46 PM

@cdisselkoen I believe we were talking past each other in the other revision - sorry about the confusion I may have caused. Hopefully this is clearer.

I have no problem with this revision. I apologize for my lack of understanding in the other revision (D88190); I was just trying to understand why having an extern const int in the C API wouldn't work. This proposal seems fine and provides more future flexibility.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 26 2020, 4:33 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.