- User Since
- Apr 30 2020, 5:53 PM (30 w, 1 d)
Oct 28 2020
In that case I believe this diff is still accepted and still just needs someone to land it?
Quick ping on this again? This diff is accepted and just needs someone to land it.
Oct 20 2020
Great! Could I ask you to land this? (I don't have sufficient privileges.)
Oct 19 2020
Friendly ping on this?
Oct 12 2020
Sep 26 2020
I have no problem with this revision. I apologize for my lack of understanding in the other revision (D88190); I was just trying to understand why having an extern const int in the C API wouldn't work. This proposal seems fine and provides more future flexibility.
Use UndefMaskElem instead of magic-number constant
Reopened per comments from @CodaFi
Sep 24 2020
This is my first contribution to LLVM, I'm not sure what the typical practice is, but if it's a normal Git commit, then Craig Disselkoen <firstname.lastname@example.org> is fine. Thanks for the review!
fix: use push_back
Use SmallVector rather than array
Sep 23 2020
whoops that isn't how arcanist works
some clang-tidy suggestions