Page MenuHomePhabricator

cdisselkoen (Craig Disselkoen)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 30 2020, 5:53 PM (30 w, 1 d)

Recent Activity

Oct 28 2020

cdisselkoen added a comment to D89816: C API: support scalable vectors.

Thanks!

Oct 28 2020, 3:24 PM · Restricted Project
cdisselkoen added a comment to D89816: C API: support scalable vectors.

In that case I believe this diff is still accepted and still just needs someone to land it?

Oct 28 2020, 1:28 PM · Restricted Project
Herald added a reviewer for D89816: C API: support scalable vectors: dexonsmith.

Quick ping on this again? This diff is accepted and just needs someone to land it.

Oct 28 2020, 11:58 AM · Restricted Project

Oct 20 2020

cdisselkoen added a comment to D89816: C API: support scalable vectors.

Great! Could I ask you to land this? (I don't have sufficient privileges.)

Oct 20 2020, 1:31 PM · Restricted Project
cdisselkoen requested review of D89816: C API: support scalable vectors.
Oct 20 2020, 12:27 PM · Restricted Project

Oct 19 2020

cdisselkoen added a comment to D89252: [C API] Add getters and setters for NUW, NSW, and Exact.

Friendly ping on this?

Oct 19 2020, 10:21 AM · Restricted Project

Oct 12 2020

cdisselkoen requested review of D89252: [C API] Add getters and setters for NUW, NSW, and Exact.
Oct 12 2020, 9:59 AM · Restricted Project

Sep 26 2020

cdisselkoen added a comment to D88367: [LLVM-C] Turn a ShuffleVector Constant Into a Getter..

I have no problem with this revision. I apologize for my lack of understanding in the other revision (D88190); I was just trying to understand why having an extern const int in the C API wouldn't work. This proposal seems fine and provides more future flexibility.

Sep 26 2020, 3:53 PM · Restricted Project
cdisselkoen added inline comments to D88190: C API: functions to get mask of a ShuffleVector.
Sep 26 2020, 3:45 PM · Restricted Project
cdisselkoen added inline comments to D88190: C API: functions to get mask of a ShuffleVector.
Sep 26 2020, 12:28 PM · Restricted Project
cdisselkoen updated the diff for D88190: C API: functions to get mask of a ShuffleVector.

Use UndefMaskElem instead of magic-number constant

Sep 26 2020, 12:28 PM · Restricted Project
cdisselkoen reopened D88190: C API: functions to get mask of a ShuffleVector.

Reopened per comments from @CodaFi

Sep 26 2020, 12:27 PM · Restricted Project
cdisselkoen added inline comments to D88190: C API: functions to get mask of a ShuffleVector.
Sep 26 2020, 12:23 PM · Restricted Project
cdisselkoen added inline comments to D88190: C API: functions to get mask of a ShuffleVector.
Sep 26 2020, 11:53 AM · Restricted Project
cdisselkoen added inline comments to D88190: C API: functions to get mask of a ShuffleVector.
Sep 26 2020, 10:41 AM · Restricted Project

Sep 24 2020

cdisselkoen added a comment to D88190: C API: functions to get mask of a ShuffleVector.

This is my first contribution to LLVM, I'm not sure what the typical practice is, but if it's a normal Git commit, then Craig Disselkoen <craigdissel@gmail.com> is fine. Thanks for the review!

Sep 24 2020, 8:08 PM · Restricted Project
cdisselkoen updated the diff for D88190: C API: functions to get mask of a ShuffleVector.

fix: use push_back

Sep 24 2020, 4:36 PM · Restricted Project
cdisselkoen added inline comments to D88190: C API: functions to get mask of a ShuffleVector.
Sep 24 2020, 4:32 PM · Restricted Project
cdisselkoen added inline comments to D88190: C API: functions to get mask of a ShuffleVector.
Sep 24 2020, 1:01 PM · Restricted Project
cdisselkoen updated the diff for D88190: C API: functions to get mask of a ShuffleVector.

Use SmallVector rather than array

Sep 24 2020, 1:00 PM · Restricted Project
cdisselkoen added inline comments to D88190: C API: functions to get mask of a ShuffleVector.
Sep 24 2020, 12:45 PM · Restricted Project

Sep 23 2020

cdisselkoen updated the diff for D88190: C API: functions to get mask of a ShuffleVector.

whoops that isn't how arcanist works

Sep 23 2020, 8:27 PM · Restricted Project
cdisselkoen updated the diff for D88190: C API: functions to get mask of a ShuffleVector.

some clang-tidy suggestions

Sep 23 2020, 8:23 PM · Restricted Project
cdisselkoen updated the summary of D88190: C API: functions to get mask of a ShuffleVector.
Sep 23 2020, 4:51 PM · Restricted Project
cdisselkoen requested review of D88190: C API: functions to get mask of a ShuffleVector.
Sep 23 2020, 4:15 PM · Restricted Project