Page MenuHomePhabricator

[flang][driver] Remove unnecessary includes in the unittest
ClosedPublic

Authored by awarzynski on Sep 24 2020, 4:59 AM.

Diff Detail

Event Timeline

awarzynski created this revision.Sep 24 2020, 4:59 AM
Herald added a project: Restricted Project. · View Herald Transcript
awarzynski requested review of this revision.Sep 24 2020, 4:59 AM
DavidTruby accepted this revision.Sep 24 2020, 5:00 AM

LGTM, perhaps put NFC in the commit message?

This revision is now accepted and ready to land.Sep 24 2020, 5:00 AM

LGTM, perhaps put NFC in the commit message?

Ta, commit msg updated!

This revision was landed with ongoing or failed builds.Sep 24 2020, 5:05 AM
This revision was automatically updated to reflect the committed changes.
flang/unittests/Frontend/CompilerInstanceTest.cpp
23

Don't we need to include #include "llvm/Support/raw_ostream.h"?

DavidTruby added inline comments.Sep 24 2020, 5:19 AM
flang/unittests/Frontend/CompilerInstanceTest.cpp
23

This builds for me so I assume it's transitively included by one of the other includes. Probably "flang/Frontend/CompilerInstance.h"?

awarzynski added inline comments.Sep 24 2020, 5:21 AM
flang/unittests/Frontend/CompilerInstanceTest.cpp
23

My bad - I searched the file for raw_ostream, but I should've searched for raw_string_ostream instead, sorry! raw_ostream.h is included via TextDiagnosticPrinter.h, so the test will continue to work.