Page MenuHomePhabricator

[CMake][AIX] Set LLVM_ENABLE_PER_TARGET_RUNTIME_DIR appropriately for AIX
ClosedPublic

Authored by daltenty on Sep 23 2020, 10:22 AM.

Details

Summary

AIX by default usually folds 32-bit & 64-bit arch libraries into a single
archive, a behaviour we may want for the runtime libraries in the future,
so we don't necessarily want to opt into the multlib layout introduce in
D45604, which is currently the default for runtime builds.

Diff Detail

Event Timeline

daltenty created this revision.Sep 23 2020, 10:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 23 2020, 10:22 AM
daltenty requested review of this revision.Sep 23 2020, 10:22 AM
llvm/runtimes/CMakeLists.txt
263

Should there be a comment on this block too?

409

s/folds/should fold/;
I would suggest to move the comment to just before the AIX block.

daltenty updated this revision to Diff 294120.Sep 24 2020, 11:29 AM
  • Adjust comments
daltenty marked 2 inline comments as done.Sep 24 2020, 11:30 AM
This revision is now accepted and ready to land.Sep 24 2020, 12:39 PM