[lld-macho] cleanup unimplemented-option warnings

[gkm]

Summary

Remove all spurious HelpHidden flags from lld/MachO/Options.td. Add test for HelpHidden to warnIfUnimplementedOption() so that the empty // handled elsewhere case is unnecessary.

[int3]

nice cleanup :)

[smeenai]

Sweet :)

You have a small typo in the commit message: s/ldd/lld/

lld/MachO/Driver.cpp

if (!opt.getGroup().isValid())
     return;
   if (opt.getGroup().getID() == OPT_grp_deprecated) {
     warn("Option `" + opt.getPrefixedName() + "' is deprecated in ld64:");
     warn(opt.getHelpText());
   }
 }
 
 static void warnIfUnimplementedOption(const opt::Option &opt) {
-  if (!opt.getGroup().isValid())
+  if (!opt.getGroup().isValid() || !opt.hasFlag(DriverFlag::HelpHidden))
     return;
   switch (opt.getGroup().getID()) {
   case OPT_grp_deprecated:
     // warn about deprecated options elsewhere
     break;
   case OPT_grp_undocumented:
     warn("Option `" + opt.getPrefixedName() +
          "' is undocumented. Should lld implement it?");
message(StringRef("Framework search paths:") +
                  : ""));
     freeArena();
     return !errorCount();
   }
 
   for (const auto &arg : args) {
     const auto &opt = arg->getOption();
     warnIfDeprecatedOption(opt);
+    warnIfUnimplementedOption(opt);
+    // TODO: are any of these better handled via filtered() or getLastArg()?
     switch (arg->getOption().getID()) {
     case OPT_INPUT:
       addFile(arg->getValue());
       break;
     case OPT_filelist:
       addFileList(arg->getValue());
       break;
     case OPT_force_load:
case OPT_framework: {
         break;
       }
       error("framework not found for -framework " + name);
       break;
     }
     case OPT_platform_version:
       handlePlatformVersion(arg);
       break;
-    case OPT_all_load:
-    case OPT_o:
-    case OPT_dylib:
-    case OPT_e:
-    case OPT_F:
-    case OPT_L:
-    case OPT_ObjC:
-    case OPT_headerpad:
-    case OPT_headerpad_max_install_names:
-    case OPT_install_name:
-    case OPT_rpath:
-    case OPT_sub_library:
-    case OPT_Z:
-    case OPT_arch:
-    case OPT_syslibroot:
-    case OPT_sectcreate:
-    case OPT_dynamic:
-      // handled elsewhere
-      break;
     default:
-      warnIfUnimplementedOption(opt);
       break;
     }
   }
 
   // Now that all dylibs have been loaded, search for those that should be
   // re-exported.
   for (opt::Arg *arg : args.filtered(OPT_sub_library)) {
     config->hasReexports = true;

lld/MachO/Options.td

def L : JoinedOrSeparate<["-"], "L">,
      HelpText<"Add dir to the library search path">,
      Group<grp_libs>;
 def Z : Flag<["-"], "Z">,
      HelpText<"Remove standard directories from the library and framework search paths">,
      Group<grp_libs>;
 def syslibroot : Separate<["-"], "syslibroot">,
      MetaVarName<"<rootdir>">,
      HelpText<"Prepend <rootdir> to all library and framework search paths">,
-     Flags<[HelpHidden]>,
      Group<grp_libs>;
 def search_paths_first : Flag<["-"], "search_paths_first">,
      HelpText<"Search for lib<name>.dylib and lib<name>.a at each step in traversing search path (default for Xcode 4 and later)">,
      Flags<[HelpHidden]>,
      Group<grp_libs>;
 def search_dylibs_first : Flag<["-"], "search_dylibs_first">,
      HelpText<"Search for lib<name>.dylib on first pass, then for lib<name>.a on second pass through search path (default for Xcode 3 and earlier)">,
      Flags<[HelpHidden]>,
      Group<grp_libs>;
 def framework : Separate<["-"], "framework">,
      MetaVarName<"<name>">,
      HelpText<"Search for <name>.framework/<name> on the framework search path">,
-     Flags<[HelpHidden]>,
      Group<grp_libs>;
 def weak_framework : Separate<["-"], "weak_framework">,
      MetaVarName<"<name>">,
      HelpText<"Like -framework <name>, but mark framework and its references as weak imports">,
      Flags<[HelpHidden]>,
      Group<grp_libs>;
 def reexport_framework : Separate<["-"], "reexport_framework">,
      MetaVarName<"<name>">,
      HelpText<"Like -framework <name>, but export all symbols of <name> from the newly created library">,
      Flags<[HelpHidden]>,
      Group<grp_libs>;
 def upward_framework : Separate<["-"], "upward_framework">,
      MetaVarName<"<name>">,
      HelpText<"Like -framework <name>, but specify the framework as an upward dependency">,
      Flags<[HelpHidden]>,
      Group<grp_libs>;
 def F : JoinedOrSeparate<["-"], "F">,
      MetaVarName<"<dir>">,
      HelpText<"Add dir to the framework search path">,
-     Flags<[HelpHidden]>,
      Group<grp_libs>;
 def all_load : Flag<["-"], "all_load">,
      HelpText<"Load all members of all static archive libraries">,
-     Flags<[HelpHidden]>,
      Group<grp_libs>;
 def ObjC : Flag<["-"], "ObjC">,
      HelpText<"Load all members of static archives that are an Objective-C class or category.">,
-     Flags<[HelpHidden]>,
      Group<grp_libs>;
 def force_load : Separate<["-"], "force_load">,
      MetaVarName<"<path>">,
      HelpText<"Load all members static archive library at <path>">,
-     Flags<[HelpHidden]>,
      Group<grp_libs>;
 
 def grp_content : OptionGroup<"content">, HelpText<"ADDITIONAL CONTENT">;
 
 def sectcreate : MultiArg<["-"], "sectcreate", 3>,
      MetaVarName<"<segment> <section> <file>">,
      HelpText<"Create <section> in <segment> from the contents of <file>">,
      Group<grp_content>;
 def segcreate : MultiArg<["-"], "segcreate", 3>,
      MetaVarName<"<segment> <section> <file>">,
      Alias<sectcreate>,
      HelpText<"Alias for -sectcreate">,
      Flags<[HelpHidden]>,
      Group<grp_content>;
 def filelist : Separate<["-"], "filelist">,
      MetaVarName<"<file>">,
      HelpText<"Read names of files to link from <file>">,
-     Flags<[HelpHidden]>,
      Group<grp_content>;
 def dtrace : Separate<["-"], "dtrace">,
      MetaVarName<"<script>">,
      HelpText<"Enable DTrace static probes according to declarations in <script>">,
      Flags<[HelpHidden]>,
      Group<grp_content>;
 
 def grp_opts : OptionGroup<"opts">, HelpText<"OPTIMIZATIONS">;
 
 def dead_strip : Flag<["-"], "dead_strip">,
      HelpText<"Remove unreachable functions and data">,
      Flags<[HelpHidden]>,
      Group<grp_opts>;
 def order_file : Separate<["-"], "order_file">,
      MetaVarName<"<file>">,
      HelpText<"Layout functions and data according to specification in <file>">,
-     Flags<[HelpHidden]>,
      Group<grp_opts>;
 def sectorder : MultiArg<["-"], "sectorder", 3>,
      MetaVarName<"<segname> <sectname> <orderfile>">,
      HelpText<"Replaced by more general -order_file option">,
      Flags<[HelpHidden]>,
      Group<grp_opts>;
 def no_order_inits : Flag<["-"], "no_order_inits">,
      HelpText<"Disable default reordering of initializer and terminator functions">,
      Flags<[HelpHidden]>,
      Group<grp_opts>;
 def no_order_data : Flag<["-"], "no_order_data">,
      HelpText<"Disable default reordering of global data accessed at launch time">,
      Flags<[HelpHidden]>,
      Group<grp_opts>;
 def platform_version : MultiArg<["-"], "platform_version", 3>,
      MetaVarName<"<platform> <min_version> <sdk_version>">,
      HelpText<"Platform (e.g., macos, ios, tvos, watchos, bridgeos, mac-catalyst, ios-sim, tvos-sim, watchos-sim, driverkit) and version numbers">,
-     Flags<[HelpHidden]>,
      Group<grp_opts>;
 def macos_version_min : Separate<["-"], "macos_version_min">,
      MetaVarName<"<version>">,
      HelpText<"Oldest macOS version for which linked output is useable">,
      Flags<[HelpHidden]>,
      Group<grp_opts>;
 def macosx_version_min : Separate<["-"], "macosx_version_min">,
      MetaVarName<"<version>">,
def bitcode_symbol_map : Separate<["-"], "bitcode_symbol_map">,
      HelpText<"Write the bitcode symbol reverse mapping to file <path>, or if a directory, to <path>/UUID.bcsymbolmap">,
      Flags<[HelpHidden]>,
      Group<grp_bitcode>;
 
 def grp_rare : OptionGroup<"rare">, HelpText<"RARELY USED">;
 
 def v : Flag<["-"], "v">,
      HelpText<"Print the linker version">,
-     Flags<[HelpHidden]>,
      Group<grp_rare>;
 def version_details : Flag<["-"], "version_details">,
      HelpText<"Print the linker version in JSON form">,
      Flags<[HelpHidden]>,
      Group<grp_rare>;
 def no_weak_imports : Flag<["-"], "no_weak_imports">,
      HelpText<"Fail if any symbols are weak imports, allowed to be NULL at runtime">,
      Flags<[HelpHidden]>,

 def init : Separate<["-"], "init">,
      MetaVarName<"<symbol>">,
      HelpText<"Run <symbol> as the first initializer in a dylib">,
      Flags<[HelpHidden]>,
      Group<grp_rare>;
 def sub_library : Separate<["-"], "sub_library">,
      MetaVarName<"<name>">,
      HelpText<"Re-export the dylib as <name>">,
-     Flags<[HelpHidden]>,
      Group<grp_rare>;
 def sub_umbrella : Separate<["-"], "sub_umbrella">,
      MetaVarName<"<name>">,
      HelpText<"Re-export the framework as <name>">,
      Flags<[HelpHidden]>,
      Group<grp_rare>;
 def allowable_client : Separate<["-"], "allowable_client">,
      MetaVarName<"<name>">,