Page MenuHomePhabricator

[lld-macho] cleanup unimplemented-option warnings
ClosedPublic

Authored by gkm on Wed, Sep 23, 9:29 AM.

Details

Reviewers
int3
smeenai
Group Reviewers
Restricted Project
Commits
rGfa5f9452120c: [lld-macho] cleanup unimplemented-option warnings
Summary

Remove all spurious HelpHidden flags from lld/MachO/Options.td. Add test for HelpHidden to warnIfUnimplementedOption() so that the empty // handled elsewhere case is unnecessary.

Diff Detail

Event Timeline

gkm created this revision.Wed, Sep 23, 9:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptWed, Sep 23, 9:29 AM
gkm requested review of this revision.Wed, Sep 23, 9:29 AM
int3 accepted this revision.Wed, Sep 23, 10:25 AM
int3 added a subscriber: int3.

nice cleanup :)

This revision is now accepted and ready to land.Wed, Sep 23, 10:25 AM
smeenai accepted this revision.Wed, Sep 23, 11:11 AM
smeenai added a subscriber: smeenai.

Sweet :)

You have a small typo in the commit message: s/ldd/lld/

gkm edited the summary of this revision. (Show Details)Wed, Sep 23, 2:31 PM
This revision was automatically updated to reflect the committed changes.