Page MenuHomePhabricator

[flang][driver] Add missing dependency in CMake files
ClosedPublic

Authored by awarzynski on Sep 22 2020, 11:42 AM.

Details

Summary

The Flang driver depends on libclangBasic. This means, among other
things, that some of the tablegen files (e.g. diagnostic definitions)
need to be generated before various libclangBasic header files can be
included (e.g. DiagnosticIDs.h). If we are lucky, libclangBasic is
indeed built before various flang driver libraries that depend on it
are. This patch makes sure that this is deterministic - i.e.
libclangBasic is built before the Flang driver libraries are.

Diff Detail

Event Timeline

awarzynski created this revision.Sep 22 2020, 11:42 AM
Herald added a project: Restricted Project. · View Herald Transcript
awarzynski requested review of this revision.Sep 22 2020, 11:42 AM
sameeranjoshi accepted this revision.Sep 23 2020, 7:16 AM
This revision is now accepted and ready to land.Sep 23 2020, 7:16 AM
This revision was automatically updated to reflect the committed changes.