[lld][test][ELF] Expand a couple of test cases for LTO behaviour

[jhenderson]

Summary

This patch expands two LTO test cases to check other aspects.

1. weak.ll has been expanded to show that it doesn't matter whether the first appearance of a weak symbol appears in a bitcode file or native object - that one is picked.
2. reproduce-lto.ll has been expanded to show that the bitcode files are stored in the reproduce package and that intermediate files (such as the LTO-compiled object) are not.

[grimar]

LGTM with a comment added. Please wait for @MaskRay.

lld/test/ELF/lto/weak.ll

10

nit: I was a bit confused looking at these names at first. I searched for 3.ll for some time until realized the naming rule used.
Perhaps, size1.ll, size2.ll and size4.ll names (and the same for *.bc) could be a bit clearer. Though, now I am fine with original naming too, so up to you.

lld/test/ELF/reproduce-lto.s

6

I'd suggest adding a comment about what exactly is tested while are you here.
Like is said in the description probably:
"Show that the bitcode files are stored in the reproduce package and that intermediate files (such as the LTO-compiled object) are not".

[jhenderson]

Rename test inputs and add comment.

[MaskRay]

LGTM.

lld/test/ELF/lto/weak.ll

 ; REQUIRES: x86
 
-;; Test weak symbols are supported in LTO.
+;; Test weak symbols are supported in LTO. The first definition should be
+;; used regardless of whether it is from a bitcode file or native object.
 
-; RUN: llvm-as %s -o %t.o
-; RUN: ld.lld %t.o %t.o -o %t.so -shared
-; RUN: llvm-readobj --symbols %t.so | FileCheck %s
+; RUN: split-file %s %t
 
-target triple = "x86_64-unknown-linux-gnu"
-target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
+; RUN: llvm-as %t/size1.ll -o %t-size1.bc
+; RUN: llvm-as %t/size2.ll -o %t-size2.bc
+; RUN: llc %t/size4.ll -o %t-size4.o -filetype=obj
+
+; RUN: ld.lld %t-size1.bc %t-size2.bc -o %t.so -shared
+; RUN: llvm-readobj --symbols %t.so | FileCheck %s -DSIZE=1
+
+; RUN: ld.lld %t-size2.bc %t-size1.bc -o %t2.so -shared
+; RUN: llvm-readobj --symbols %t2.so | FileCheck %s -DSIZE=2
+
+; RUN: ld.lld %t-size1.bc %t-size4.o -o %t3.so -shared
+; RUN: llvm-readobj --symbols %t3.so | FileCheck %s -DSIZE=1
 
-define weak void @f() {
-  ret void
-}
+; RUN: ld.lld %t-size4.o %t-size1.bc -o %t4.so -shared
+; RUN: llvm-readobj --symbols %t4.so | FileCheck %s -DSIZE=4
 
-; CHECK:      Name: f
+; CHECK:      Name: a
 ; CHECK-NEXT: Value:
-; CHECK-NEXT: Size: 1
+; CHECK-NEXT: Size: [[SIZE]]
 ; CHECK-NEXT: Binding: Weak
-; CHECK-NEXT: Type: Function
+; CHECK-NEXT: Type: Object
 ; CHECK-NEXT: Other: 0
-; CHECK-NEXT: Section: .text
+; CHECK-NEXT: Section: .data
+
+;--- size1.ll
+target triple = "x86_64-unknown-linux-gnu"
+target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
+
+@a = weak global i8 1
+
+;--- size2.ll
+target triple = "x86_64-unknown-linux-gnu"
+target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
+
+@a = weak global i16 1
+
+;--- size4.ll
+target triple = "x86_64-unknown-linux-gnu"
+target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
+
+@a = weak global i32 1

lld/test/ELF/reproduce-lto.s

 # REQUIRES: x86
+## Show that bitcode files and inputs to LTO-related options are stored in the
+## reproduce package and that intermediate files (such as the LTO-compiled
+## object) are not.
 
 # RUN: rm -rf %t.dir
 # RUN: mkdir -p %t.dir/build1
 # RUN: llvm-mc -filetype=obj -triple=x86_64 %s -o %t.dir/build1/foo.o
 # RUN: echo > %t.dir/build1/empty_profile.txt
 # RUN: cd %t.dir
 # RUN: ld.lld build1/foo.o -o /dev/null --reproduce repro1.tar --lto-sample-profile=%t.dir/build1/empty_profile.txt
-# RUN: tar tvf repro1.tar | FileCheck %s
-# CHECK: repro1/{{.*}}/empty_profile.txt
+# RUN: tar tvf repro1.tar | FileCheck %s --implicit-check-not={{.}}
+
+# CHECK-DAG: {{.*}} repro1/{{.*}}/empty_profile.txt
+# CHECK-DAG: {{.*}} repro1/response.txt
+# CHECK-DAG: {{.*}} repro1/version.txt
+# CHECK-DAG: {{.*}} repro1/{{.*}}/foo.o