This is an archive of the discontinued LLVM Phabricator instance.

Differential D88025

[NFC][mlir] Remove llvm:: prefix from SmallVector in parallel pretty printer.
ClosedPublic

Authored by DavidTruby on Sep 21 2020, 8:23 AM.

Details

Reviewers
ftynse
Commits
rGbf202b8ce77c: [NFC][mlir] Remove llvm:: prefix from SmallVector in parallel pretty printer.
Summary

This prefix is unnecessary as SmallVector is re-exported in the mlir namespace.

Diff Detail

Revision Contents

PathSize
mlir/
lib/
Dialect/
OpenMP/
IR/
20 lines

Diff 293442

mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp

Show First 20 Lines • Show All 120 Lines • ▼ Show 20 Lines
/// default ::= `default` `(` (`private` | `firstprivate` | `shared` | `none`) /// default ::= `default` `(` (`private` | `firstprivate` | `shared` | `none`)
/// procBind ::= `proc_bind` `(` (`master` | `close` | `spread`) `)` /// procBind ::= `proc_bind` `(` (`master` | `close` | `spread`) `)`
/// ///
/// Note that each clause can only appear once in the clase-list. /// Note that each clause can only appear once in the clase-list.
static ParseResult parseParallelOp(OpAsmParser &parser, static ParseResult parseParallelOp(OpAsmParser &parser,
OperationState &result) { OperationState &result) {
std::pair<OpAsmParser::OperandType, Type> ifCond; std::pair<OpAsmParser::OperandType, Type> ifCond;
std::pair<OpAsmParser::OperandType, Type> numThreads; std::pair<OpAsmParser::OperandType, Type> numThreads;
llvm::SmallVector<OpAsmParser::OperandType, 4> privates; SmallVector<OpAsmParser::OperandType, 4> privates;
llvm::SmallVector<Type, 4> privateTypes; SmallVector<Type, 4> privateTypes;
llvm::SmallVector<OpAsmParser::OperandType, 4> firstprivates; SmallVector<OpAsmParser::OperandType, 4> firstprivates;
llvm::SmallVector<Type, 4> firstprivateTypes; SmallVector<Type, 4> firstprivateTypes;
llvm::SmallVector<OpAsmParser::OperandType, 4> shareds; SmallVector<OpAsmParser::OperandType, 4> shareds;
llvm::SmallVector<Type, 4> sharedTypes; SmallVector<Type, 4> sharedTypes;
llvm::SmallVector<OpAsmParser::OperandType, 4> copyins; SmallVector<OpAsmParser::OperandType, 4> copyins;
llvm::SmallVector<Type, 4> copyinTypes; SmallVector<Type, 4> copyinTypes;
std::array<int, 6> segments{0, 0, 0, 0, 0, 0}; std::array<int, 6> segments{0, 0, 0, 0, 0, 0};
llvm::StringRef keyword; llvm::StringRef keyword;
bool defaultVal = false; bool defaultVal = false;
bool procBind = false; bool procBind = false;
const int ifClausePos = 0; const int ifClausePos = 0;
const int numThreadsClausePos = 1; const int numThreadsClausePos = 1;
const int privateClausePos = 2; const int privateClausePos = 2;
▲ Show 20 Lines • Show All 114 Lines • ▼ Show 20 Lines if (segments[copyinClausePos]) {
parser.resolveOperands(copyins, copyinTypes, copyins[0].location, parser.resolveOperands(copyins, copyinTypes, copyins[0].location,
result.operands); result.operands);
} }
result.addAttribute("operand_segment_sizes", result.addAttribute("operand_segment_sizes",
parser.getBuilder().getI32VectorAttr(segments)); parser.getBuilder().getI32VectorAttr(segments));
Region *body = result.addRegion(); Region *body = result.addRegion();
llvm::SmallVector<OpAsmParser::OperandType, 4> regionArgs; SmallVector<OpAsmParser::OperandType, 4> regionArgs;
llvm::SmallVector<Type, 4> regionArgTypes; SmallVector<Type, 4> regionArgTypes;
if (parser.parseRegion(*body, regionArgs, regionArgTypes)) if (parser.parseRegion(*body, regionArgs, regionArgTypes))
return failure(); return failure();
return success(); return success();
} }
#define GET_OP_CLASSES #define GET_OP_CLASSES
#include "mlir/Dialect/OpenMP/OpenMPOps.cpp.inc" #include "mlir/Dialect/OpenMP/OpenMPOps.cpp.inc"