Page MenuHomePhabricator

WIP: DSL-style builder generator
AbandonedPublic

Authored by ftynse on Sep 21 2020, 3:41 AM.

Details

Reviewers
None

Diff Detail

Event Timeline

ftynse created this revision.Sep 21 2020, 3:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 21 2020, 3:41 AM
ftynse requested review of this revision.Sep 21 2020, 3:41 AM

Overall, should we discuss whether we want a per-dialect builder or put that on per-op (i.e, Op::create) to not have another object involved in this (the dialect builder). I know you had pointed me to an earlier discussion, I didn't get an opportunity to carry it forward.

mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp
2249

FYI: I just added an OpMethodParameter to represent something like this. May be the OpMethodParameters create() functions can have this parsing logic and vend out an OpMethodResolvedParameters objects instead of the current OpMethodUnresolvedParameters?

I have sent an RFC to which this diff is in illustration. Please do not review diffs with work-in-progress / WIP in the title.

ftynse abandoned this revision.Jan 6 2021, 4:10 AM