Page MenuHomePhabricator

[AIX][clang][driver] Make sure crti[_64].o is linked in C++ mode
ClosedPublic

Authored by daltenty on Sep 18 2020, 11:59 AM.

Details

Summary

since crti is required for functional static initialization.

Diff Detail

Event Timeline

daltenty created this revision.Sep 18 2020, 11:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 18 2020, 11:59 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
daltenty requested review of this revision.Sep 18 2020, 11:59 AM
clang/test/Driver/aix-ld.c
16–17

There should be checks for not having crti*.o on the C invocations (at least insofar as we decided that we were going to have checks for not having -lc++).

332

I think this is right but is worth noting. The dynamic initialization/finalization functionality is of a more fundamental nature.

hubert.reinterpretcast retitled this revision from [AIX][clang][driver] Make sure ctri.o is linked in C++ mode to [AIX][clang][driver] Make sure crti[_64].o is linked in C++ mode.Sep 21 2020, 2:00 PM
daltenty updated this revision to Diff 293262.Sep 21 2020, 2:57 PM
  • Check absence in C cases
  • Add a note about crti in the nostdlib++ case
This revision is now accepted and ready to land.Sep 21 2020, 3:34 PM