This is an archive of the discontinued LLVM Phabricator instance.

Differential D87803

[lld-macho] Ignore `-mllvm` and its argument
ClosedPublic

Authored by int3 on Sep 16 2020, 4:08 PM.

Details

Reviewers
compnerd
MaskRay
Group Reviewers
Restricted Project
Commits
rG79412d6ca772: [lld-macho] Ignore `-mllvm` and its argument
Summary

Test Plan:

Diff Detail

Event Timeline

int3 created this revision.Sep 16 2020, 4:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 16 2020, 4:08 PM
Herald added subscribers: llvm-commits, dang. · View Herald Transcript
int3 requested review of this revision.Sep 16 2020, 4:08 PM
Harbormaster completed remote builds in B71942: Diff 292367.Sep 16 2020, 4:08 PM
compnerd accepted this revision.Sep 16 2020, 4:33 PM
This revision is now accepted and ready to land.Sep 16 2020, 4:33 PM
MaskRay accepted this revision.Sep 16 2020, 5:07 PM
MaskRay added a subscriber: MaskRay.
MaskRay added inline comments.
lld/MachO/Options.td
860

If you ignore an option, you can use def :

int3 added inline comments.Sep 17 2020, 12:54 PM
lld/MachO/Options.td
860

I'd prefer to follow what the rest of the file is currently doing -- using HelpHidden to mark ignored options

int3 added a parent revision: D87780: [lld-macho] Export trie addresses should be relative to the image base.Sep 17 2020, 3:52 PM
int3 added a child revision: D87852: [lld-macho] Allow the entry symbol to be dynamically bound.
This revision was landed with ongoing or failed builds.Sep 23 2020, 7:27 PM
Closed by commit rG79412d6ca772: [lld-macho] Ignore `-mllvm` and its argument (authored by int3). · Explain Why
This revision was automatically updated to reflect the committed changes.
int3 added a commit: rG79412d6ca772: [lld-macho] Ignore `-mllvm` and its argument.

Revision Contents

PathSize
lld/
MachO/
8 lines
test/
MachO/
2 lines

Diff 293922

lld/MachO/Options.td

Show First 20 Lines • Show All 851 Lines • ▼ Show 20 Lines
def page_align_data_atoms : Flag<["-"], "page_align_data_atoms">, def page_align_data_atoms : Flag<["-"], "page_align_data_atoms">,
HelpText<"Distribute global variables on separate pages so page used/dirty status can guide creation of an order file to cluster commonly used/dirty globals">, HelpText<"Distribute global variables on separate pages so page used/dirty status can guide creation of an order file to cluster commonly used/dirty globals">,
Flags<[HelpHidden]>, Flags<[HelpHidden]>,
Group<grp_rare>; Group<grp_rare>;
def not_for_dyld_shared_cache : Flag<["-"], "not_for_dyld_shared_cache">, def not_for_dyld_shared_cache : Flag<["-"], "not_for_dyld_shared_cache">,
HelpText<"Prevent system dylibs from being placed into the dylib shared cache">, HelpText<"Prevent system dylibs from being placed into the dylib shared cache">,
Flags<[HelpHidden]>, Flags<[HelpHidden]>,
Group<grp_rare>; Group<grp_rare>;
def mllvm : Separate<["-"], "mllvm">,
MaskRayUnsubmitted
Not Done
ReplyInline Actions

If you ignore an option, you can use def :

MaskRay: If you ignore an option, you can use `def :`
int3AuthorUnsubmitted
Done
ReplyInline Actions

I'd prefer to follow what the rest of the file is currently doing -- using HelpHidden to mark ignored options

int3: I'd prefer to follow what the rest of the file is currently doing -- using `HelpHidden` to mark…
HelpText<"Options to pass to LLVM">,
Flags<[HelpHidden]>,
Group<grp_rare>;
def grp_deprecated : OptionGroup<"deprecated">, HelpText<"DEPRECATED">; def grp_deprecated : OptionGroup<"deprecated">, HelpText<"DEPRECATED">;
def lazy_framework : Separate<["-"], "lazy_framework">, def lazy_framework : Separate<["-"], "lazy_framework">,
MetaVarName<"<name>">, MetaVarName<"<name>">,
HelpText<"This option is deprecated and is now an alias for -framework.">, HelpText<"This option is deprecated and is now an alias for -framework.">,
Flags<[HelpHidden]>, Flags<[HelpHidden]>,
Group<grp_deprecated>; Group<grp_deprecated>;
▲ Show 20 Lines • Show All 322 Lines • ▼ Show 20 Linesdef uikitformac_version_min : Flag<["-"], "uikitformac_version_min">,
Alias<maccatalyst_version_min>, Alias<maccatalyst_version_min>,
HelpText<"Alias for -maccatalyst_version_min">, HelpText<"Alias for -maccatalyst_version_min">,
Flags<[HelpHidden]>, Flags<[HelpHidden]>,
Group<grp_undocumented>; Group<grp_undocumented>;
def mcpu : Flag<["-"], "mcpu">, def mcpu : Flag<["-"], "mcpu">,
HelpText<"This option is undocumented in ld64">, HelpText<"This option is undocumented in ld64">,
Flags<[HelpHidden]>, Flags<[HelpHidden]>,
Group<grp_undocumented>; Group<grp_undocumented>;
def mllvm : Flag<["-"], "mllvm">,
HelpText<"This option is undocumented in ld64">,
Flags<[HelpHidden]>,
Group<grp_undocumented>;
def no_compact_unwind : Flag<["-"], "no_compact_unwind">, def no_compact_unwind : Flag<["-"], "no_compact_unwind">,
HelpText<"This option is undocumented in ld64">, HelpText<"This option is undocumented in ld64">,
Flags<[HelpHidden]>, Flags<[HelpHidden]>,
Group<grp_undocumented>; Group<grp_undocumented>;
def no_dtrace_dof : Flag<["-"], "no_dtrace_dof">, def no_dtrace_dof : Flag<["-"], "no_dtrace_dof">,
HelpText<"This option is undocumented in ld64">, HelpText<"This option is undocumented in ld64">,
Flags<[HelpHidden]>, Flags<[HelpHidden]>,
Group<grp_undocumented>; Group<grp_undocumented>;
▲ Show 20 Lines • Show All 71 Lines • Show Last 20 Lines

lld/test/MachO/silent-ignore.test

RUN: lld -flavor darwinnew -v \ RUN: lld -flavor darwinnew -v \
RUN: -demangle \ RUN: -demangle \
RUN: -dynamic \ RUN: -dynamic \
RUN: -no_deduplicate \ RUN: -no_deduplicate \
RUN: -lto_library /lib/foo \ RUN: -lto_library /lib/foo \
RUN: -macosx_version_min 0 \ RUN: -macosx_version_min 0 \
RUN: -dependency_info /path/to/dependency_info.dat \ RUN: -dependency_info /path/to/dependency_info.dat \
RUN: -syslibroot /path/to/MacOSX.platform/Developer/SDKs/MacOSX.sdk RUN: -mllvm -time-passes
RUN: not lld -flavor darwinnew -v --not-an-ignored-argument 2>&1 | FileCheck %s RUN: not lld -flavor darwinnew -v --not-an-ignored-argument 2>&1 | FileCheck %s
CHECK: error: unknown argument: --not-an-ignored-argument CHECK: error: unknown argument: --not-an-ignored-argument