This is an archive of the discontinued LLVM Phabricator instance.

Differential D87783

[Flang] Fixed installation permission of the "binary" flang
ClosedPublic

Authored by tianshilei1992 on Sep 16 2020, 12:04 PM.

Details

Reviewers
DavidTruby
sscalpone
Commits
rGd89c5ae85772: [Flang] Fixed installation permission of the "binary" flang
Summary

Under current configuration, the permission of flang after installation is 700.
This could bring a problem for system administrators who build and install flang
for other users, which only the user who builds LLVM can execute it, and others
can not. In this patch, the explicit permission setting in the install command
is removed, and let CMake determine what perssion to be used like other components.

Diff Detail

Event Timeline

tianshilei1992 created this revision.Sep 16 2020, 12:04 PM
Herald added a reviewer: DavidTruby. · View Herald TranscriptSep 16 2020, 12:04 PM
Herald added a reviewer: sscalpone. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, mgorny. · View Herald Transcript
tianshilei1992 requested review of this revision.Sep 16 2020, 12:04 PM
Harbormaster completed remote builds in B71913: Diff 292300.Sep 16 2020, 12:29 PM
DavidTruby accepted this revision.Sep 16 2020, 2:55 PM

LGTM

This revision is now accepted and ready to land.Sep 16 2020, 2:55 PM
tianshilei1992 updated this revision to Diff 292361.Sep 16 2020, 3:10 PM

Rebase and trigger a new test

Harbormaster completed remote builds in B71938: Diff 292361.Sep 16 2020, 3:25 PM
This revision was landed with ongoing or failed builds.Sep 16 2020, 3:54 PM
Closed by commit rGd89c5ae85772: [Flang] Fixed installation permission of the "binary" flang (authored by tianshilei1992). · Explain Why
This revision was automatically updated to reflect the committed changes.
tianshilei1992 added a commit: rGd89c5ae85772: [Flang] Fixed installation permission of the "binary" flang.

Revision Contents

PathSize
flang/
tools/
f18/
2 lines

Diff 292366

flang/tools/f18/CMakeLists.txt

Show First 20 Lines • Show All 78 Lines • ▼ Show 20 Linesif (NOT WIN32)
endif() endif()
endif() endif()
# The flang script to be installed needs a different path to the headers. # The flang script to be installed needs a different path to the headers.
set(FLANG_INTRINSIC_MODULES_DIR ${CMAKE_INSTALL_PREFIX}/include/flang) set(FLANG_INTRINSIC_MODULES_DIR ${CMAKE_INSTALL_PREFIX}/include/flang)
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/flang.sh.in ${FLANG_BINARY_DIR}/bin/flang-install.sh @ONLY) configure_file(${CMAKE_CURRENT_SOURCE_DIR}/flang.sh.in ${FLANG_BINARY_DIR}/bin/flang-install.sh @ONLY)
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/f18_version.h.in ${CMAKE_CURRENT_BINARY_DIR}/f18_version.h @ONLY) configure_file(${CMAKE_CURRENT_SOURCE_DIR}/f18_version.h.in ${CMAKE_CURRENT_BINARY_DIR}/f18_version.h @ONLY)
install(PROGRAMS ${FLANG_BINARY_DIR}/bin/flang-install.sh DESTINATION bin RENAME flang PERMISSIONS OWNER_EXECUTE OWNER_READ OWNER_WRITE) install(PROGRAMS ${FLANG_BINARY_DIR}/bin/flang-install.sh DESTINATION bin RENAME flang)