This is an archive of the discontinued LLVM Phabricator instance.

Differential D87664

[NewPM][opt] Fix -globals-aa not being recognized as alias analysis in NPM
ClosedPublic

Authored by aeubanks on Sep 14 2020, 6:40 PM.

Details

Reviewers
ychen
asbirlea
Commits
rG3f69b2140f55: [NewPM][opt] Fix -globals-aa not being recognized as alias analysis in NPM
Summary

Was missing MODULE_ALIAS_ANALYSIS, previously only FUNCTION_ALIAS_ANALYSIS was taken into account.

Diff Detail

Event Timeline

aeubanks created this revision.Sep 14 2020, 6:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 14 2020, 6:40 PM
Herald added subscribers: llvm-commits, hiraditya. · View Herald Transcript
aeubanks requested review of this revision.Sep 14 2020, 6:40 PM
Harbormaster completed remote builds in B71667: Diff 291755.Sep 14 2020, 7:14 PM
asbirlea accepted this revision.Sep 14 2020, 7:22 PM
asbirlea added inline comments.
llvm/test/Analysis/GlobalsModRef/comdat-ipo.ll
1–2

Add -enable-new-pm=0 on the first line?

This revision is now accepted and ready to land.Sep 14 2020, 7:22 PM
aeubanks updated this revision to Diff 291979.Sep 15 2020, 11:14 AM

add -enable-new-pm=0

This revision was landed with ongoing or failed builds.Sep 15 2020, 11:18 AM
Closed by commit rG3f69b2140f55: [NewPM][opt] Fix -globals-aa not being recognized as alias analysis in NPM (authored by aeubanks). · Explain Why
This revision was automatically updated to reflect the committed changes.
aeubanks added a commit: rG3f69b2140f55: [NewPM][opt] Fix -globals-aa not being recognized as alias analysis in NPM.
Harbormaster completed remote builds in B71765: Diff 291979.Sep 15 2020, 11:43 AM

Revision Contents

PathSize
llvm/
lib/
Passes/
3 lines
test/
Analysis/
GlobalsModRef/
3 lines

Diff 291981

llvm/lib/Passes/PassBuilder.cpp

Show First 20 Lines • Show All 2,781 Lines • ▼ Show 20 Lines if (!parseAAPassName(AA, Name))
formatv("unknown alias analysis name '{0}'", Name).str(), formatv("unknown alias analysis name '{0}'", Name).str(),
inconvertibleErrorCode()); inconvertibleErrorCode());
} }
return Error::success(); return Error::success();
} }
bool PassBuilder::isAAPassName(StringRef PassName) { bool PassBuilder::isAAPassName(StringRef PassName) {
#define MODULE_ALIAS_ANALYSIS(NAME, CREATE_PASS) \
if (PassName == NAME) \
return true;
#define FUNCTION_ALIAS_ANALYSIS(NAME, CREATE_PASS) \ #define FUNCTION_ALIAS_ANALYSIS(NAME, CREATE_PASS) \
if (PassName == NAME) \ if (PassName == NAME) \
return true; return true;
#include "PassRegistry.def" #include "PassRegistry.def"
return false; return false;
} }
bool PassBuilder::isAnalysisPassName(StringRef PassName) { bool PassBuilder::isAnalysisPassName(StringRef PassName) {
Show All 15 Lines

llvm/test/Analysis/GlobalsModRef/comdat-ipo.ll

; RUN: opt < %s -basic-aa -globals-aa -gvn -S | FileCheck %s ; RUN: opt < %s -basic-aa -globals-aa -gvn -enable-new-pm=0 -S | FileCheck %s
; RUN: opt < %s -basic-aa -globals-aa -gvn -enable-new-pm=1 -S | FileCheck %s
asbirleaUnsubmitted
Not Done
ReplyInline Actions

Add -enable-new-pm=0 on the first line?

asbirlea: Add `-enable-new-pm=0` on the first line?
; See PR26774 ; See PR26774
@X = internal global i32 4 @X = internal global i32 4
define i32 @test(i32* %P) { define i32 @test(i32* %P) {
; CHECK: @test ; CHECK: @test
; CHECK-NEXT: store i32 12, i32* @X ; CHECK-NEXT: store i32 12, i32* @X
Show All 12 Lines