Page MenuHomePhabricator

Speedup collecting DWARF attribute values
AbandonedPublic

Authored by dmantipov on Sep 10 2020, 1:51 AM.

Details

Summary

Try to speedup collecting DWARF attribute values by using emplace_back() to avoid extra calls to copy and/or move constructors.

Diff Detail

Event Timeline

dmantipov created this revision.Sep 10 2020, 1:51 AM
dmantipov requested review of this revision.Sep 10 2020, 1:51 AM
aprantl added inline comments.Sep 11 2020, 8:22 AM
lldb/source/Plugins/SymbolFile/DWARF/DWARFAttribute.h
83

We usually don't prefix constructor arguments. Most LLDB code would write this as
m_cu(cu) for classes and cu(cu) for structs.

shafik added a subscriber: shafik.Sep 13 2020, 9:43 PM
shafik added inline comments.
lldb/source/Plugins/SymbolFile/DWARF/DWARFAttribute.h
83

Why not drop the prefixes all together? I don't see what they add here.

dmantipov updated this revision to Diff 291519.Sep 14 2020, 2:30 AM

Drop prefixes and tweak the style to match clang-format requirements.