Page MenuHomePhabricator

dmantipov (Dmitry Antipov)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 4 2020, 7:19 AM (6 w, 5 d)

Recent Activity

Mon, Sep 28

dmantipov committed rGbc868da0e77a: [Driver] Filter out <libdir>/gcc and <libdir>/gcc-cross if they do not exists (authored by dmantipov).
[Driver] Filter out <libdir>/gcc and <libdir>/gcc-cross if they do not exists
Mon, Sep 28, 11:20 PM
dmantipov closed D87901: [Driver] Filter out <libdir>/gcc and <libdir>/gcc-cross if they do not exists.
Mon, Sep 28, 11:19 PM · Restricted Project
dmantipov added a comment to D87901: [Driver] Filter out <libdir>/gcc and <libdir>/gcc-cross if they do not exists.

Thanks @MaskRay for the method, some of my numbers are shown below.

Mon, Sep 28, 8:20 PM · Restricted Project
dmantipov updated the diff for D87901: [Driver] Filter out <libdir>/gcc and <libdir>/gcc-cross if they do not exists.

Prefer locals and function parameters to class members.

Mon, Sep 28, 8:16 PM · Restricted Project
dmantipov updated the diff for D87901: [Driver] Filter out <libdir>/gcc and <libdir>/gcc-cross if they do not exists.

Initialize GCCDirExists and GCCCrossDirExists before calling ScanLibDirForGCCTriple().

Mon, Sep 28, 1:42 AM · Restricted Project
dmantipov added a comment to D87901: [Driver] Filter out <libdir>/gcc and <libdir>/gcc-cross if they do not exists.

@MaskRay Sure clang does not need to be installed and does not need to be beside GCC. But usually it is, and IMO this is the convenient setup for the most users who are not involved in development of clang itself and probably rely on tools installed as OS vendor's defaults. On my Fedora 32 system, I have /usr/bin/g++ and /usr/bin/clang++ (commonly configured with prefix /usr), clang will look for GCC installation in /usr/lib/gcc/x86_64-redhat-linux, and so.

Mon, Sep 28, 1:10 AM · Restricted Project
dmantipov added a comment to D87901: [Driver] Filter out <libdir>/gcc and <libdir>/gcc-cross if they do not exists.
Mon, Sep 28, 12:57 AM · Restricted Project

Fri, Sep 25

dmantipov added a reviewer for D87901: [Driver] Filter out <libdir>/gcc and <libdir>/gcc-cross if they do not exists: MaskRay.
Fri, Sep 25, 11:42 PM · Restricted Project
dmantipov added a reviewer for D87901: [Driver] Filter out <libdir>/gcc and <libdir>/gcc-cross if they do not exists: aganea.
Fri, Sep 25, 11:40 PM · Restricted Project
dmantipov committed rG2ca0ea15e5c9: [Driver] Fix formatting as suggested by clang-format (NFC) (authored by dmantipov).
[Driver] Fix formatting as suggested by clang-format (NFC)
Fri, Sep 25, 10:53 PM
dmantipov committed rG96318f64a786: [Driver] Perform Linux distribution detection only once (authored by dmantipov).
[Driver] Perform Linux distribution detection only once
Fri, Sep 25, 10:51 PM
dmantipov closed D87187: [Driver] Perform Linux distribution detection just once.
Fri, Sep 25, 10:50 PM · Restricted Project
dmantipov updated the diff for D87187: [Driver] Perform Linux distribution detection just once.

Well, the problem with tests seems to be a bit wider - tests uses llvm::vfs::InMemoryFileSystem, which is not "real", so detection will return Distro::UnknownDistro anyway. So I think we can just add fallback branch for such pseudo filesystems and live with current tests as is.

Fri, Sep 25, 7:31 AM · Restricted Project

Thu, Sep 24

dmantipov updated the diff for D87901: [Driver] Filter out <libdir>/gcc and <libdir>/gcc-cross if they do not exists.

Prefer a bit more meaningful variable names.

Thu, Sep 24, 12:39 AM · Restricted Project
dmantipov updated the diff for D87187: [Driver] Perform Linux distribution detection just once.

IIUC compiler driver is not intended to be multithreaded. But OK, here is the version with llvm::call_once(...).

Thu, Sep 24, 12:30 AM · Restricted Project

Wed, Sep 23

dmantipov added a comment to D87187: [Driver] Perform Linux distribution detection just once.

What's next with this? Should I add more reviewers?

Wed, Sep 23, 11:01 AM · Restricted Project
dmantipov committed rGd882ca7f1f1d: [Driver] Check whether Gentoo-specific configuration directory exists (authored by dmantipov).
[Driver] Check whether Gentoo-specific configuration directory exists
Wed, Sep 23, 10:26 AM
dmantipov closed D87143: Check whether Gentoo-specific configuration directory exists.
Wed, Sep 23, 10:26 AM · Restricted Project
dmantipov committed rG68358081585b: Add optimal thread strategy (authored by dmantipov).
Add optimal thread strategy
Wed, Sep 23, 9:45 AM
dmantipov closed D87765: [llvm][lldb] Add optimal ThreadPool concurrency.
Wed, Sep 23, 9:44 AM · Restricted Project, Restricted Project

Sep 18 2020

dmantipov requested review of D87901: [Driver] Filter out <libdir>/gcc and <libdir>/gcc-cross if they do not exists.
Sep 18 2020, 6:12 AM · Restricted Project
dmantipov updated the diff for D87187: [Driver] Perform Linux distribution detection just once.

Updated (style adjustments).

Sep 18 2020, 12:15 AM · Restricted Project

Sep 16 2020

dmantipov added a comment to D87765: [llvm][lldb] Add optimal ThreadPool concurrency.

Running on 48-core system, I was pretty surprised to see 48-threads pool when attempting to debug a toy C++ program. So here is a fix.

Sep 16 2020, 8:04 AM · Restricted Project, Restricted Project
dmantipov requested review of D87765: [llvm][lldb] Add optimal ThreadPool concurrency.
Sep 16 2020, 8:03 AM · Restricted Project, Restricted Project

Sep 15 2020

dmantipov updated the diff for D87675: [lldb/DWARF] Refactor to prefer emplace_back() vs. push_back().

OK let's reduce it to minimum minimorum.

Sep 15 2020, 6:52 AM · Restricted Project
dmantipov updated the diff for D87675: [lldb/DWARF] Refactor to prefer emplace_back() vs. push_back().

Use std::pair rather than an ad-hoc two-member trivial structures. Since std::pair provides the default constructor to initialize both members, no extra C++ glue is required for emplace_back()'ing the pairs into containers.

Sep 15 2020, 5:24 AM · Restricted Project
dmantipov updated the diff for D87675: [lldb/DWARF] Refactor to prefer emplace_back() vs. push_back().

Minor style adjustments.

Sep 15 2020, 2:31 AM · Restricted Project
dmantipov abandoned D87441: Speedup collecting DWARF attribute values.

Superseded with https://reviews.llvm.org/D87675.

Sep 15 2020, 2:14 AM · Restricted Project
dmantipov requested review of D87675: [lldb/DWARF] Refactor to prefer emplace_back() vs. push_back().
Sep 15 2020, 2:13 AM · Restricted Project

Sep 14 2020

dmantipov updated the diff for D87441: Speedup collecting DWARF attribute values.

Drop prefixes and tweak the style to match clang-format requirements.

Sep 14 2020, 2:30 AM · Restricted Project

Sep 10 2020

dmantipov requested review of D87441: Speedup collecting DWARF attribute values.
Sep 10 2020, 1:51 AM · Restricted Project

Sep 9 2020

dmantipov added a reviewer for D87187: [Driver] Perform Linux distribution detection just once: sylvestre.ledru.
Sep 9 2020, 10:55 PM · Restricted Project
dmantipov accepted D87143: Check whether Gentoo-specific configuration directory exists.
Sep 9 2020, 10:53 PM · Restricted Project

Sep 7 2020

dmantipov updated the diff for D87187: [Driver] Perform Linux distribution detection just once.

Add trivial {/etc,/usr/lib}/os-release parser and fix tests.

Sep 7 2020, 6:55 AM · Restricted Project

Sep 5 2020

dmantipov requested review of D87187: [Driver] Perform Linux distribution detection just once.
Sep 5 2020, 4:45 AM · Restricted Project

Sep 4 2020

dmantipov updated the diff for D87143: Check whether Gentoo-specific configuration directory exists.

Add D.SysRoot as suggested during initial review.

Sep 4 2020, 11:05 AM · Restricted Project
dmantipov requested review of D87143: Check whether Gentoo-specific configuration directory exists.
Sep 4 2020, 7:35 AM · Restricted Project