Page MenuHomePhabricator

[WebAssembly] Set unreachable as canonical to permit disassembly
ClosedPublic

Authored by ddcc on Sep 9 2020, 10:06 PM.

Details

Summary

Currently, using llvm-objdump to disassemble a function containing
unreachable will trigger an assertion while decoding the opcode, since both
unreachable and debug_unreachable have the same encoding. To avoid this, set
unreachable as the canonical decoding.

Diff Detail

Event Timeline

ddcc created this revision.Sep 9 2020, 10:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 9 2020, 10:06 PM
ddcc requested review of this revision.Sep 9 2020, 10:06 PM
dschuff accepted this revision.Sep 10 2020, 10:00 AM
This revision is now accepted and ready to land.Sep 10 2020, 10:00 AM
tlively accepted this revision.Sep 10 2020, 10:51 AM