By default all threads available on the machines are being used
by the Buildbot. This patch limits the use of threads to 256.
This is definitely needed as it is really overloading the machine. However I can't really approve it as I am not familiar with the Python code here.
I don't see this argument being passed to any other calls to SanitizerBuilder.getSanitizerBuildFactory() but I assume it works the same as it does with other factory functions. Would like to get some confirmation from someone more familiar though.
Unfortunately, SanitizerBuilder.getSanitizerBuildFactory does not accept accept extra_configure_args argument and does not pass it down to the script.
You would need to propose a patch to support this.
I also do not see the zorg/buildbot/builders/sanitizers/buildbot_selector.py accepting and passing further additional cmake args, so you would likely need to add support there as well.
It seems that most builders do have the extra_configure_args parameter but the builder that we use here does not.
You may have to add the parameter to the build factory to get this to work.
I don't think that this is going to work this easily. It doesn't look like extra_configure_args is part of the call to getSanitizerBuildFactory().
def getSanitizerBuildFactory( clean=False, depends_on_projects=None, env=None, timeout=1200):
Whereas other builders do have it. For example in ClangLTOBuilder.py:
def getClangWithLTOBuildFactory( depends_on_projects = None, clean = False, jobs = None, extra_configure_args = None, ... <more options here> ...
You may have to add the parameter to getSanitizerBuildFactory and then use it in the body of the function.