Page MenuHomePhabricator

[objdump][macho] Emit segment names along with section names
ClosedPublic

Authored by dsanders on Sep 3 2020, 5:12 PM.

Details

Summary

I recently came across a MachO with multiple sections of the same name but
different segments. We should emit the segment name alongside the section name
for MachO's.

Diff Detail

Unit TestsFailed

TimeTest
190 mslinux > lld.MachO::local-got.s
Script: -- : 'RUN: at line 2'; mkdir -p /mnt/disks/ssd0/agent/llvm-project/build/tools/lld/test/MachO/Output/local-got.s.tmp
120 mslinux > lld.MachO::relocations.s
Script: -- : 'RUN: at line 2'; /mnt/disks/ssd0/agent/llvm-project/build/bin/llvm-mc -filetype=obj -triple=x86_64-apple-darwin /mnt/disks/ssd0/agent/llvm-project/lld/test/MachO/relocations.s -o /mnt/disks/ssd0/agent/llvm-project/build/tools/lld/test/MachO/Output/relocations.s.tmp.o
90 mslinux > lld.MachO::sectcreate.s
Script: -- : 'RUN: at line 2'; /mnt/disks/ssd0/agent/llvm-project/build/bin/llvm-mc -filetype=obj -triple=x86_64-apple-darwin /mnt/disks/ssd0/agent/llvm-project/lld/test/MachO/sectcreate.s -o /mnt/disks/ssd0/agent/llvm-project/build/tools/lld/test/MachO/Output/sectcreate.s.tmp.o
110 mslinux > lld.MachO::section-merge.s
Script: -- : 'RUN: at line 2'; mkdir -p /mnt/disks/ssd0/agent/llvm-project/build/tools/lld/test/MachO/Output/section-merge.s.tmp
100 mslinux > lld.MachO::weak-binding.s
Script: -- : 'RUN: at line 2'; split-file /mnt/disks/ssd0/agent/llvm-project/lld/test/MachO/weak-binding.s /mnt/disks/ssd0/agent/llvm-project/build/tools/lld/test/MachO/Output/weak-binding.s.tmp
View Full Test Results (16 Failed)

Event Timeline

dsanders created this revision.Sep 3 2020, 5:12 PM
Herald added a reviewer: MaskRay. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: rupprecht. · View Herald Transcript
dsanders requested review of this revision.Sep 3 2020, 5:12 PM
pete accepted this revision.Sep 3 2020, 5:14 PM

LGTM

This revision is now accepted and ready to land.Sep 3 2020, 5:14 PM
This revision was landed with ongoing or failed builds.Sep 4 2020, 9:57 AM
This revision was automatically updated to reflect the committed changes.