Page MenuHomePhabricator

[OpenMPOpt] Assume indirect call always changes ICV
ClosedPublic

Authored by weiwang on Sep 3 2020, 11:27 AM.

Details

Summary

When checking call sites, give special handling to indirect call, as the
callee may be unknown and can lead to nullptr dereference later. Assume
conservatively that the ICV always changes in such case.

Diff Detail

Event Timeline

weiwang created this revision.Sep 3 2020, 11:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 3 2020, 11:27 AM
weiwang requested review of this revision.Sep 3 2020, 11:27 AM
weiwang edited the summary of this revision. (Show Details)Sep 3 2020, 11:31 AM
weiwang added a subscriber: hoyFB.
weiwang updated this revision to Diff 289870.Sep 3 2020, 10:59 PM

Add test case for indirect call. Without the fix, the test will crash.

sstefan1 accepted this revision.Sep 3 2020, 11:01 PM

LGTM, thanks!

This revision is now accepted and ready to land.Sep 3 2020, 11:01 PM
weiwang edited the summary of this revision. (Show Details)Sep 4 2020, 9:00 AM
This revision was automatically updated to reflect the committed changes.