Page MenuHomePhabricator

weiwang (Wei Wang)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 20 2020, 2:20 PM (9 w, 1 d)

Recent Activity

Mon, Sep 21

weiwang updated the diff for D85810: [clang] Pass-through remarks options to linker.

minor update to test case

Mon, Sep 21, 4:58 PM · Restricted Project
weiwang updated the diff for D85810: [clang] Pass-through remarks options to linker.
  1. remove unreachable code
  2. udpate test case
Mon, Sep 21, 4:07 PM · Restricted Project

Thu, Sep 17

weiwang added inline comments to D85810: [clang] Pass-through remarks options to linker.
Thu, Sep 17, 5:25 PM · Restricted Project
weiwang updated the diff for D85810: [clang] Pass-through remarks options to linker.

update test case

Thu, Sep 17, 5:20 PM · Restricted Project

Fri, Sep 4

weiwang updated the summary of D87104: [OpenMPOpt] Assume indirect call always changes ICV.
Fri, Sep 4, 9:00 AM · Restricted Project

Thu, Sep 3

weiwang updated the diff for D87104: [OpenMPOpt] Assume indirect call always changes ICV.

Add test case for indirect call. Without the fix, the test will crash.

Thu, Sep 3, 10:59 PM · Restricted Project
weiwang updated subscribers of D87104: [OpenMPOpt] Assume indirect call always changes ICV.
Thu, Sep 3, 11:32 AM · Restricted Project
weiwang updated the summary of D87104: [OpenMPOpt] Assume indirect call always changes ICV.
Thu, Sep 3, 11:31 AM · Restricted Project
weiwang added a reviewer for D87104: [OpenMPOpt] Assume indirect call always changes ICV: sstefan1.
Thu, Sep 3, 11:28 AM · Restricted Project
weiwang requested review of D87104: [OpenMPOpt] Assume indirect call always changes ICV.
Thu, Sep 3, 11:27 AM · Restricted Project

Wed, Sep 2

weiwang added a comment to D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

Really appreciate the feedbacks. If there is no more, could anyone approve 3 changes? Thanks.

Wed, Sep 2, 5:37 PM · Restricted Project

Thu, Aug 27

weiwang updated the diff for D85810: [clang] Pass-through remarks options to linker.

remove redundant check

Thu, Aug 27, 1:43 PM · Restricted Project
weiwang added inline comments to D85810: [clang] Pass-through remarks options to linker.
Thu, Aug 27, 1:27 PM · Restricted Project
weiwang added inline comments to D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools.
Thu, Aug 27, 1:24 PM · Restricted Project, Restricted Project

Aug 19 2020

weiwang updated the diff for D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

try to fix windows build linking error.

Aug 19 2020, 9:44 AM · Restricted Project

Aug 18 2020

weiwang updated the diff for D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

try to fix windows build error. Use fully qualified name for enum value Optional.

Aug 18 2020, 10:06 PM · Restricted Project
weiwang updated the diff for D84715: [FIX] Avoid creating BFI when emitting remarks for dead functions.

add comment on test case.

Aug 18 2020, 8:53 PM · Restricted Project
weiwang updated the diff for D85810: [clang] Pass-through remarks options to linker.

fix typo

Aug 18 2020, 8:38 PM · Restricted Project
weiwang added inline comments to D85810: [clang] Pass-through remarks options to linker.
Aug 18 2020, 8:36 PM · Restricted Project
weiwang updated the diff for D85810: [clang] Pass-through remarks options to linker.

coding style change

Aug 18 2020, 8:35 PM · Restricted Project
weiwang updated the diff for D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

Try to fix a windows build error. No msvc available locally, so even with this change, the build could still fail.

Aug 18 2020, 8:33 PM · Restricted Project

Aug 17 2020

weiwang updated the diff for D85810: [clang] Pass-through remarks options to linker.

move some unrelated change into parent diff.

Aug 17 2020, 10:56 PM · Restricted Project
weiwang updated the summary of D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.
Aug 17 2020, 10:55 PM · Restricted Project
weiwang retitled D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools from [remarks] Optimization remarks hotness filtering from profile summary to [Remarks][2/2] Expand remarks hotness threshold option support in more tools.
Aug 17 2020, 10:55 PM · Restricted Project, Restricted Project
weiwang updated the diff for D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools.

update:

  1. reorganize code splitting with parent diff.
  2. format and style change.
Aug 17 2020, 10:53 PM · Restricted Project, Restricted Project
weiwang updated the summary of D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.
Aug 17 2020, 10:50 PM · Restricted Project
weiwang retitled D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools from [LTO] Make setupLLVMOptimizationRemarks accept remarks hotness threshold to [Remarks][1/2] Expand remarks hotness threshold option support in more tools.
Aug 17 2020, 10:50 PM · Restricted Project
weiwang updated the diff for D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

update:

  1. move internal remarks hotness threshold type change and its related handling code from child diff into this one. With this move, remarks hotness threshold now accepts 'auto' value, but its handling is currently disabled.
  2. format change.
Aug 17 2020, 10:48 PM · Restricted Project
weiwang added inline comments to D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.
Aug 17 2020, 3:34 PM · Restricted Project
weiwang updated the summary of D84715: [FIX] Avoid creating BFI when emitting remarks for dead functions.
Aug 17 2020, 3:16 PM · Restricted Project
weiwang retitled D84715: [FIX] Avoid creating BFI when emitting remarks for dead functions from [FIX] Add check for empty body function to [FIX] Avoid creating BFI when emitting remarks for dead functions.
Aug 17 2020, 3:15 PM · Restricted Project
weiwang updated the diff for D84715: [FIX] Avoid creating BFI when emitting remarks for dead functions.

Instead of adding checks for all passes/analyses, use light-weight ORE to emit remarks for dead functions.

Aug 17 2020, 3:14 PM · Restricted Project
weiwang updated the summary of D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.
Aug 17 2020, 1:24 PM · Restricted Project
weiwang retitled D85810: [clang] Pass-through remarks options to linker from [clang] Pass-through remarks options to lld to [clang] Pass-through remarks options to linker.
Aug 17 2020, 1:16 PM · Restricted Project
weiwang updated the diff for D85810: [clang] Pass-through remarks options to linker.

update:

  1. add --plugin-opt alias for remarks in lld
  2. handle both lld and ld.gold pass-through
  3. simplify target checking logic
  4. code format update
Aug 17 2020, 1:12 PM · Restricted Project
weiwang updated the diff for D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

format update

Aug 17 2020, 1:08 PM · Restricted Project
weiwang updated the diff for D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

format update

Aug 17 2020, 1:07 PM · Restricted Project
weiwang retitled D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools from [lld] Enable remarks hotness filtering in lld and llvm-lto2 to [LTO] Make setupLLVMOptimizationRemarks accept remarks hotness threshold.
Aug 17 2020, 1:00 PM · Restricted Project
weiwang updated the diff for D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

update:
add remarks hotness threshold to all the tools uses lto::setupLLVMOptimizationRemarks

Aug 17 2020, 12:59 PM · Restricted Project

Aug 13 2020

weiwang added a comment to D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

The changes to *LTOCodeGenerator and the test using llvm-lto are unrelated to lld (they are the old LTO API used by ld64). So they should be moved to a different patch or the patch name changed. Would be good to add llvm-lto2 tests which exercise the new LTO API changed in LTO.cpp, LTOBackend.cpp etc. Note those changes are broader than just lld (also used by gold-plugin).

Aug 13 2020, 7:00 PM · Restricted Project
weiwang retitled D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools from [lld] Enable remarks hotness filtering in lld to [lld] Enable remarks hotness filtering in lld and llvm-lto2.
Aug 13 2020, 6:58 PM · Restricted Project
weiwang updated the diff for D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

changes:

  1. revert the change made to llvm-lto.
  2. add the new option to llvm-lto2 wit test cases.
Aug 13 2020, 6:56 PM · Restricted Project
weiwang added a comment to D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools.

This is the 3rd of 3 dependent patches:

  1. [lld] Enable remarks hotness filtering in lld: https://reviews.llvm.org/D85809
  2. [clang] Pass-through remarks options to lld: https://reviews.llvm.org/D85810
  3. [remarks] Optimization remarks hotness filtering from profile summary: https://reviews.llvm.org/D85808

You can relate these as Parent/Child patches in Phabricator. See "Edit Related Revisions" on the top right. It helps reviewers to see the relationship and keep track of what patches are still open.

Note these relationships get set up automatically when you upload a patch with "Depends on Dxxxxx." in the description.

Aug 13 2020, 4:54 PM · Restricted Project, Restricted Project

Aug 12 2020

weiwang updated the diff for D85810: [clang] Pass-through remarks options to linker.

update test case

Aug 12 2020, 4:18 PM · Restricted Project
weiwang updated the diff for D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

clang-format

Aug 12 2020, 2:59 PM · Restricted Project
weiwang abandoned D85856: [lld] Enable remarks hotness filtering in lld.
Aug 12 2020, 2:46 PM · Restricted Project
weiwang requested review of D85856: [lld] Enable remarks hotness filtering in lld.
Aug 12 2020, 2:46 PM · Restricted Project

Aug 11 2020

weiwang abandoned D84246: [clang][LTO] Pass-through remarks options and set auto hotness threshold.

Diff has been split into 3 smaller ones:

Aug 11 2020, 10:56 PM · Restricted Project, Restricted Project
weiwang retitled D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools from [remarks] Optimization remarks hotness filetering from profile summary to [remarks] Optimization remarks hotness filtering from profile summary.
Aug 11 2020, 10:53 PM · Restricted Project, Restricted Project
weiwang added reviewers for D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools: wenlei, hoyFB.

This is the 3rd of 3 dependent patches:

  1. [lld] Enable remarks hotness filtering in lld: https://reviews.llvm.org/D85809
  2. [clang] Pass-through remarks options to lld: https://reviews.llvm.org/D85810
  3. [remarks] Optimization remarks hotness filtering from profile summary: https://reviews.llvm.org/D85808
Aug 11 2020, 10:51 PM · Restricted Project, Restricted Project
weiwang added reviewers for D85810: [clang] Pass-through remarks options to linker: wenlei, hoyFB.

This is the 2nd of 3 dependent patches:

  1. [lld] Enable remarks hotness filtering in lld: https://reviews.llvm.org/D85809
  2. [clang] Pass-through remarks options to lld: https://reviews.llvm.org/D85810
  3. [remarks] Optimization remarks hotness filtering from profile summary: https://reviews.llvm.org/D85808
Aug 11 2020, 10:50 PM · Restricted Project
weiwang added reviewers for D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools: wenlei, hoyFB.

This is the 1st of 3 dependent patches:

  1. [lld] Enable remarks hotness filtering in lld: https://reviews.llvm.org/D85809
  2. [clang] Pass-through remarks options to lld: https://reviews.llvm.org/D85810
  3. [remarks] Optimization remarks hotness filtering from profile summary: https://reviews.llvm.org/D85808
Aug 11 2020, 10:49 PM · Restricted Project
weiwang requested review of D85810: [clang] Pass-through remarks options to linker.
Aug 11 2020, 10:44 PM · Restricted Project
weiwang requested review of D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.
Aug 11 2020, 10:44 PM · Restricted Project
weiwang requested review of D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools.
Aug 11 2020, 10:37 PM · Restricted Project, Restricted Project

Aug 3 2020

weiwang added a comment to D84246: [clang][LTO] Pass-through remarks options and set auto hotness threshold.

still waiting for inputs. Thanks.

Aug 3 2020, 9:34 AM · Restricted Project, Restricted Project

Jul 30 2020

weiwang updated the diff for D84715: [FIX] Avoid creating BFI when emitting remarks for dead functions.

add test case

Jul 30 2020, 5:23 PM · Restricted Project

Jul 28 2020

weiwang added a comment to D84715: [FIX] Avoid creating BFI when emitting remarks for dead functions.

I'm guessing these are not the only passes that will choke with empty/dead functions. If this is because ORE is being used for a special case, then we might want to fix the special case on the user side.

If we want passes to absorb such empty functions, then there needs to be consistency for all passes. I don't think passes need to absorb such cases though, as this is really a "limbo state" of functions when being removed (a normal empty function should still have entry block and ret instruction).

Jul 28 2020, 9:42 AM · Restricted Project

Jul 27 2020

weiwang updated subscribers of D84720: [FIX] Resolve test failure in polly/test/ScopInfo/memcpy-raw-source.ll.
Jul 27 2020, 7:46 PM · Restricted Project
weiwang added a reviewer for D84720: [FIX] Resolve test failure in polly/test/ScopInfo/memcpy-raw-source.ll: aeubanks.
Jul 27 2020, 7:46 PM · Restricted Project
Herald added a project to D84720: [FIX] Resolve test failure in polly/test/ScopInfo/memcpy-raw-source.ll: Restricted Project.
Jul 27 2020, 7:44 PM · Restricted Project
weiwang added reviewers for D84715: [FIX] Avoid creating BFI when emitting remarks for dead functions: xazax.hun, MaskRay.
Jul 27 2020, 5:25 PM · Restricted Project
weiwang updated subscribers of D84715: [FIX] Avoid creating BFI when emitting remarks for dead functions.
Jul 27 2020, 5:21 PM · Restricted Project
weiwang added a comment to D84715: [FIX] Avoid creating BFI when emitting remarks for dead functions.

To reproduce:

  1. create test file main.cpp
Jul 27 2020, 5:15 PM · Restricted Project
weiwang updated the summary of D84715: [FIX] Avoid creating BFI when emitting remarks for dead functions.
Jul 27 2020, 5:10 PM · Restricted Project
weiwang updated the summary of D84715: [FIX] Avoid creating BFI when emitting remarks for dead functions.
Jul 27 2020, 4:53 PM · Restricted Project
Herald added a project to D84715: [FIX] Avoid creating BFI when emitting remarks for dead functions: Restricted Project.
Jul 27 2020, 4:52 PM · Restricted Project
weiwang updated the diff for D84246: [clang][LTO] Pass-through remarks options and set auto hotness threshold.

Fix msvc build failure

Jul 27 2020, 4:13 PM · Restricted Project, Restricted Project
weiwang added a comment to D84246: [clang][LTO] Pass-through remarks options and set auto hotness threshold.

I put everything together in a single diff so that it is easier to get the whole idea. The change itself is too big to go in as a single diff, and I'd like to get inputs on how to split it.

Jul 27 2020, 2:23 PM · Restricted Project, Restricted Project

Jul 21 2020

Herald added projects to D84246: [clang][LTO] Pass-through remarks options and set auto hotness threshold: Restricted Project, Restricted Project.
Jul 21 2020, 9:13 AM · Restricted Project, Restricted Project