User Details
- User Since
- Jul 20 2020, 2:20 PM (27 w, 9 h)
Dec 1 2020
Ah, I am sorry. Thanks for fixing it.
Nov 30 2020
- Fix typo.
- Minor order adjustment in testcase.
rebase
rebase
@tejohnson @MaskRay Do you have other comments?
@tejohnson @MaskRay Do you have other comments?
Nov 18 2020
- Add clang test with remarks output.
- Fix a missing dependency on PSI in legacy pass manager.
Nov 17 2020
revert back MSVC fix
update to address MSVC build error
update test case
update test case for clang option pass-through
Thanks! I will wait for his input.
Nov 16 2020
@MaskRay @tejohnson, do you have other comments regarding this change and its dependent?
add test case
Nov 13 2020
Oct 27 2020
Diff was committed, but did not close automatically. Manual close it now.
fix typo
Oct 26 2020
Oct 23 2020
Sorry for the long delay. Got held up by some other task.
Oct 15 2020
Oct 13 2020
Thanks for the comment, Craig.
Oct 6 2020
Thanks @MaskRay ! I am really sorry I didn't catch up your comments earlier. My email somehow stops giving me notifications on diff updates.
Address Comments.
Sep 28 2020
@tejohnson @MaskRay Do you have other comments to the change?
@tejohnson @MaskRay Do you have other comments to the change?
Sep 21 2020
minor update to test case
- remove unreachable code
- udpate test case
Sep 17 2020
update test case
Sep 4 2020
Sep 3 2020
Add test case for indirect call. Without the fix, the test will crash.
Sep 2 2020
Really appreciate the feedbacks. If there is no more, could anyone approve 3 changes? Thanks.
Aug 27 2020
remove redundant check
Aug 19 2020
try to fix windows build linking error.
Aug 18 2020
try to fix windows build error. Use fully qualified name for enum value Optional.
add comment on test case.
fix typo
coding style change
Try to fix a windows build error. No msvc available locally, so even with this change, the build could still fail.
Aug 17 2020
move some unrelated change into parent diff.
update:
- reorganize code splitting with parent diff.
- format and style change.
update:
- move internal remarks hotness threshold type change and its related handling code from child diff into this one. With this move, remarks hotness threshold now accepts 'auto' value, but its handling is currently disabled.
- format change.
Instead of adding checks for all passes/analyses, use light-weight ORE to emit remarks for dead functions.
update:
- add --plugin-opt alias for remarks in lld
- handle both lld and ld.gold pass-through
- simplify target checking logic
- code format update
format update
format update
update:
add remarks hotness threshold to all the tools uses lto::setupLLVMOptimizationRemarks
Aug 13 2020
changes:
- revert the change made to llvm-lto.
- add the new option to llvm-lto2 wit test cases.
Aug 12 2020
update test case
clang-format
Aug 11 2020
Diff has been split into 3 smaller ones:
This is the 3rd of 3 dependent patches:
- [lld] Enable remarks hotness filtering in lld: https://reviews.llvm.org/D85809
- [clang] Pass-through remarks options to lld: https://reviews.llvm.org/D85810
- [remarks] Optimization remarks hotness filtering from profile summary: https://reviews.llvm.org/D85808
This is the 2nd of 3 dependent patches:
- [lld] Enable remarks hotness filtering in lld: https://reviews.llvm.org/D85809
- [clang] Pass-through remarks options to lld: https://reviews.llvm.org/D85810
- [remarks] Optimization remarks hotness filtering from profile summary: https://reviews.llvm.org/D85808