This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Don't build llvm-lit in RUNTIMES-BUILD
ClosedPublic

Authored by jsji on Sep 1 2020, 9:28 PM.

Details

Summary

With runtimes-build, we lost map config for llvm-lit, so we can NOT run
lit from source dir anymore.
All the subdir target like: ninja check-llvm-codegen-powerpc will fail
too.

We will get some cfg error like:

File "../lvm-project/llvm/test/lit.cfg.py", line 21, in <module>
  config.test_format = lit.formats.ShTest(not llvm_config.use_lit_shell)

AttributeError: 'NoneType' object has no attribute 'use_lit_shell'

This is reset of map config in llvm-lit rebuild.
We already have llvm-lit in runtimes-build, so don't build it.

Diff Detail

Event Timeline

jsji created this revision.Sep 1 2020, 9:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 1 2020, 9:28 PM
Herald added subscribers: Restricted Project, steven.zhang, mgorny, dberris. · View Herald Transcript
jsji requested review of this revision.Sep 1 2020, 9:28 PM
phosek accepted this revision.Sep 1 2020, 11:06 PM

LGTM

This revision is now accepted and ready to land.Sep 1 2020, 11:06 PM
jsji updated this revision to Diff 289563.Sep 2 2020, 2:13 PM

Move up the condition to avoid unecessary warning about LLVM_EXTERNAL_LIT.

This revision was automatically updated to reflect the committed changes.