This is an archive of the discontinued LLVM Phabricator instance.

add SPIR-V GLSL extended Round op
ClosedPublic

Authored by haoyouab on Sep 1 2020, 12:52 AM.

Diff Detail

Event Timeline

haoyouab created this revision.Sep 1 2020, 12:52 AM
haoyouab requested review of this revision.Sep 1 2020, 12:52 AM
XinWang added a subscriber: XinWang.Sep 1 2020, 2:05 AM
mravishankar requested changes to this revision.Sep 1 2020, 10:30 AM

Thanks! Can we also add some tests for the operation here and serialization roundtrip tests here. This is in keeping with the procedure to add new op here

This revision now requires changes to proceed.Sep 1 2020, 10:30 AM
haoyouab updated this revision to Diff 289351.Sep 1 2020, 9:55 PM

add tests and serialization roundtrip tests for SPIR-V GLSL Round op

antiagainst accepted this revision.Sep 2 2020, 8:30 AM
mravishankar accepted this revision.Sep 2 2020, 9:16 AM
This revision is now accepted and ready to land.Sep 2 2020, 9:16 AM

Hi, I'm a first-time contributor. Just an ask about the landing/pushing process. Is there anyone who's gonna push this commit for me cause I don't have access?

Sure thing. Happy to do that. Thanks for the contribution!

This revision was automatically updated to reflect the committed changes.