This is an archive of the discontinued LLVM Phabricator instance.

[DebugInfo] Remove Dwarf5AccelTableWriter::Header::UnitLength. NFC.
ClosedPublic

Authored by ikudrin on Aug 31 2020, 11:49 PM.

Details

Summary

The member is not in use; the unit length for the table is emitted as a difference between two labels. Moreover, the type of the member might be misleading, because for DWARF64 the field should be 64 bit long.

Diff Detail

Event Timeline

ikudrin created this revision.Aug 31 2020, 11:49 PM
ikudrin requested review of this revision.Aug 31 2020, 11:49 PM
dblaikie accepted this revision.Sep 1 2020, 12:15 AM

Sounds good

This revision is now accepted and ready to land.Sep 1 2020, 12:15 AM
jhenderson accepted this revision.Sep 1 2020, 2:34 AM

Makes sense to me too.