Page MenuHomePhabricator

Remove leftover REQUIRES: global-isel
ClosedPublic

Authored by russell.gallop on Aug 27 2020, 7:22 AM.

Diff Detail

Event Timeline

russell.gallop created this revision.Aug 27 2020, 7:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 27 2020, 7:22 AM
russell.gallop requested review of this revision.Aug 27 2020, 7:22 AM
arsenm added inline comments.Aug 27 2020, 7:23 AM
llvm/test/CodeGen/MIR/AArch64/generic-virtual-registers-error.mir
3

I assume something in lit is parsing and recognizing this? Should remove that too?

russell.gallop updated this revision to Diff 288328.EditedAug 27 2020, 7:40 AM
russell.gallop added a reviewer: qcolombet.

I assume something in lit is parsing and recognizing this? Should remove that too?

Yes, there were a few bits left over in lit and llvm-config, so I've removed them.

I'm assuming BUILD.gn can take care of itself...

arsenm accepted this revision.Aug 27 2020, 7:41 AM
This revision is now accepted and ready to land.Aug 27 2020, 7:41 AM

Fix llvm-config test.

arsenm accepted this revision.Aug 27 2020, 8:33 AM

I think somethings wrong. I'm now seeing this on all global isel tests:

UNSUPPORTED: LLVM :: CodeGen/AMDGPU/GlobalISel/regbankselect-umin.mir (704 of 740)

I think somethings wrong. I'm now seeing this on all global isel tests:

UNSUPPORTED: LLVM :: CodeGen/AMDGPU/GlobalISel/regbankselect-umin.mir (704 of 740)

Fixed leftover lit.local.cfgs in 9607ccf62617c9f025d182ddf137cf80e6d5c1f0

Thanks for catching that.