This is an archive of the discontinued LLVM Phabricator instance.

Differential D86703

Fix Attributor return status
ClosedPublic

Authored by serge-sans-paille on Aug 27 2020, 5:39 AM.

Details

Reviewers
jdoerfert
uenoku
sstefan1
baziotis
Commits
rG5621571fc7fc: Fix Attributor return status
Summary

Removing functions does change the IR :-)

This is a requirement for https://reviews.llvm.org/D86589

Diff Detail

Event Timeline

serge-sans-paille created this revision.Aug 27 2020, 5:39 AM
Herald added a reviewer: uenoku. · View Herald TranscriptAug 27 2020, 5:39 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, okura, kuter and 2 others. · View Herald Transcript
serge-sans-paille requested review of this revision.Aug 27 2020, 5:39 AM
Herald added a reviewer: sstefan1. · View Herald TranscriptAug 27 2020, 5:39 AM
Herald added a reviewer: baziotis. · View Herald Transcript
Herald added a subscriber: bbn. · View Herald Transcript
jdoerfert accepted this revision.Aug 27 2020, 5:46 AM

LGTM

This revision is now accepted and ready to land.Aug 27 2020, 5:46 AM
Closed by commit rG5621571fc7fc: Fix Attributor return status (authored by serge-sans-paille). · Explain WhyAug 27 2020, 6:01 AM
This revision was automatically updated to reflect the committed changes.
serge-sans-paille added a commit: rG5621571fc7fc: Fix Attributor return status.

Revision Contents

PathSize
llvm/
lib/
Transforms/
IPO/
3 lines

Diff 288300

llvm/lib/Transforms/IPO/Attributor.cpp

Show First 20 Lines • Show All 1,295 Lines • ▼ Show 20 LinesChangeStatus Attributor::cleanupIR() {
ChangeStatus ManifestChange = rewriteFunctionSignatures(CGModifiedFunctions); ChangeStatus ManifestChange = rewriteFunctionSignatures(CGModifiedFunctions);
for (Function *Fn : CGModifiedFunctions) for (Function *Fn : CGModifiedFunctions)
CGUpdater.reanalyzeFunction(*Fn); CGUpdater.reanalyzeFunction(*Fn);
for (Function *Fn : ToBeDeletedFunctions) for (Function *Fn : ToBeDeletedFunctions)
CGUpdater.removeFunction(*Fn); CGUpdater.removeFunction(*Fn);
if (!ToBeDeletedFunctions.empty())
ManifestChange = ChangeStatus::CHANGED;
NumFnDeleted += ToBeDeletedFunctions.size(); NumFnDeleted += ToBeDeletedFunctions.size();
LLVM_DEBUG(dbgs() << "[Attributor] Deleted " << NumFnDeleted LLVM_DEBUG(dbgs() << "[Attributor] Deleted " << NumFnDeleted
<< " functions after manifest.\n"); << " functions after manifest.\n");
#ifdef EXPENSIVE_CHECKS #ifdef EXPENSIVE_CHECKS
for (Function *F : Functions) { for (Function *F : Functions) {
if (ToBeDeletedFunctions.count(F)) if (ToBeDeletedFunctions.count(F))
▲ Show 20 Lines • Show All 1,188 Lines • Show Last 20 Lines