[LLD] [COFF] Error out if creating a DLL with too many exported symbols

[mstorsjo]

Summary

The PE/DLL format has a limit on 64k exported symbols per DLL; make sure to check this.

[amccarth]

The change looks fine.

For testing, I like the idea of one function exported with 64K names. What about an object file that has just one function, and a module-definition file (.DEF file) that exports 64K aliases of it at link time? The .DEF file would be about as large as your generated .c file is now, but the object file would be tiny.

I'd have no concerns about generating the test inputs on demand--that's done quite a bit for the debugger tests--but lld is not my baby.

[mstorsjo]

Added a testcase with a tiny python script that generates def files that export the same symbol a number of times. It generates two 566 KB def files, for testing the case below and above the limit. The successful link case produces a 1 MB DLL and a 8 MB import library.

[amccarth]

I like it.

lld/COFF/DriverUtils.cpp

 #include "llvm/Option/Option.h"
 #include "llvm/Support/CommandLine.h"
 #include "llvm/Support/FileUtilities.h"
 #include "llvm/Support/MathExtras.h"
 #include "llvm/Support/Process.h"
 #include "llvm/Support/Program.h"
 #include "llvm/Support/raw_ostream.h"
 #include "llvm/WindowsManifest/WindowsManifestMerger.h"
+#include <limits>
 #include <memory>
 
 using namespace llvm::COFF;
 using namespace llvm;
 using llvm::sys::Process;
 
 namespace lld {
 namespace coff {
void fixupExports() {
   std::sort(config->exports.begin(), config->exports.end(),
             [](const Export &a, const Export &b) {
               return a.exportName < b.exportName;
             });
 }
 
 void assignExportOrdinals() {
   // Assign unique ordinals if default (= 0).
-  uint16_t max = 0;
+  uint32_t max = 0;
   for (Export &e : config->exports)
-    max = std::max(max, e.ordinal);
+    max = std::max(max, (uint32_t)e.ordinal);
   for (Export &e : config->exports)
     if (e.ordinal == 0)
       e.ordinal = ++max;
+  if (max > std::numeric_limits<uint16_t>::max())
+    fatal("too many exported symbols (max " +
+          Twine(std::numeric_limits<uint16_t>::max()) + ")");
 }
 
 // Parses a string in the form of "key=value" and check
 // if value matches previous values for the same key.
 void checkFailIfMismatch(StringRef arg, InputFile *source) {
   StringRef k, v;
   std::tie(k, v) = arg.split('=');
   if (k.empty() || v.empty())

lld/test/COFF/Inputs/def-many.py

+import sys
+
+print("EXPORTS")
+for i in range(0, int(sys.argv[1])):
+  print("f%d=f" % (i))

lld/test/COFF/export-limit.s

+# REQUIRES: x86
+# RUN: %python %p/Inputs/def-many.py 65535 > %t-65535.def
+# RUN: %python %p/Inputs/def-many.py 65536 > %t-65536.def
+# RUN: llvm-mc -triple x86_64-win32 %s -filetype=obj -o %t.obj
+# RUN: lld-link -dll -noentry %t.obj -out:%t.dll -def:%t-65535.def
+# RUN: not lld-link -dll -noentry %t.obj -out:%t.dll -def:%t-65536.def 2>&1 | FileCheck %s
+
+# CHECK: error: too many exported symbols
+
+        .text
+        .globl f
+f:
+        ret