[LLD] [MinGW] Enable dynamicbase by default
ClosedPublic
Actions

Authored by mstorsjo on Aug 26 2020, 12:54 PM.

Details

Reviewers

amccarth
mati865
jacek
ruiu

Commits

rGe72403f96de7: [LLD] [MinGW] Enable dynamicbase by default

Summary

This matches lld-link's own default.

Add a new command line option --no-dynamicbase for disabling it. (Unfortunately, GNU ld doesn't yet have a matching --no-dynamicbase option, as that's the default there.)

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

mstorsjo created this revision.Aug 26 2020, 12:54 PM

Herald added a project: Restricted Project. · View Herald TranscriptAug 26 2020, 12:54 PM

Herald added a subscriber: dang. · View Herald Transcript

mstorsjo requested review of this revision.Aug 26 2020, 12:54 PM

LGTM.

This revision is now accepted and ready to land.Aug 26 2020, 2:34 PM

Harbormaster completed remote builds in B69665: Diff 288085.Aug 26 2020, 2:39 PM

This really should have been the default for years but it didn't work properly with ld.bfd: https://github.com/msys2/MINGW-packages/issues/6674
Since it already work good with COFF backend when targeting MSVC I'm strongly in favour of enabling it for MinGW as well.

Closed by commit rGe72403f96de7: [LLD] [MinGW] Enable dynamicbase by default (authored by mstorsjo). · Explain WhyAug 27 2020, 5:11 AM

This revision was automatically updated to reflect the committed changes.

mstorsjo added a commit: rGe72403f96de7: [LLD] [MinGW] Enable dynamicbase by default.