This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][GlobalISel] Remove some duplicate RUN lines
ClosedPublic

Authored by foad on Aug 26 2020, 6:10 AM.

Diff Detail

Event Timeline

foad created this revision.Aug 26 2020, 6:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 26 2020, 6:10 AM
foad requested review of this revision.Aug 26 2020, 6:10 AM
foad added a reviewer: arsenm.Aug 26 2020, 6:11 AM

Were these tests supposed to be testing HSA or some other non-MESA target? It makes a difference for legalize-load-constant but not for legalize-load-flat.

This was probably intended to test with unaligned access enabled or not

arsenm added a comment.Jan 7 2021, 7:39 AM

Is this still needed?

foad added a comment.Jan 11 2021, 4:14 AM

Is this still needed?

Well the RUN lines are still useless duplicates.

I tried adding -mattr=+unaligned-access-mode and -mattr=-unaligned-access-mode but neither made any difference to any of the tests. Can I just remove them?

arsenm accepted this revision.Jan 11 2021, 7:00 PM
This revision is now accepted and ready to land.Jan 11 2021, 7:00 PM
This revision was automatically updated to reflect the committed changes.