This is an archive of the discontinued LLVM Phabricator instance.

Differential D86599

[libcxx] Add cmake cache file for BUILD_EXTERNAL_THREAD_LIBRARY
AbandonedPublic

Authored by Nicu on Aug 26 2020, 1:51 AM.

Details

Reviewers
ldionne
miyuki
Group Reviewers
Restricted Project
Summary

[libcxx] Add cmake cache file for BUILD_EXTERNAL_THREAD_LIBRARY

Add a new cmake cache file for automatically providing the configuration
to build libcxx with -DLIBCXX_BUILD_EXTERNAL_THREAD_LIBRARY.

Diff Detail

Event Timeline

Nicu created this revision.Aug 26 2020, 1:51 AM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptAug 26 2020, 1:51 AM
Herald added subscribers: libcxx-commits, mgorny. · View Herald Transcript
Nicu requested review of this revision.Aug 26 2020, 1:51 AM
Harbormaster completed remote builds in B69548: Diff 287868.Aug 26 2020, 1:58 AM
Nicu added a parent revision: D86598: [libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY.Aug 26 2020, 4:21 AM
miyuki added a reviewer: ldionne.Aug 26 2020, 5:55 AM
Herald added a subscriber: dexonsmith. · View Herald TranscriptAug 26 2020, 5:55 AM
miyuki added a reviewer: miyuki.Aug 26 2020, 5:56 AM
ldionne mentioned this in D86704: [libcxx] Add testing infrastructure for EXTERNAL_THREAD_API mode.Aug 27 2020, 7:54 AM
Nicu abandoned this revision.Sep 1 2020, 8:22 AM

@ldionne I'm closing this revision, as changes have been included in revision https://reviews.llvm.org/D86704 as you requested.

Revision Contents

PathSize
libcxx/
cmake/
caches/
2 lines

Diff 287868

libcxx/cmake/caches/Build-ext-thread-lib.cmake

  • This file was added.
set(LIBCXX_CXX_ABI libcxxabi CACHE STRING "")
set(LIBCXX_BUILD_EXTERNAL_THREAD_LIBRARY ON CACHE BOOL "")