Page MenuHomePhabricator

Nicu (David Nicuesa)
User

Projects

User does not belong to any projects.

User Details

User Since
May 20 2020, 2:51 AM (22 w, 2 d)

Recent Activity

Sep 8 2020

Nicu added a comment to D86704: [libcxx] Add testing infrastructure for EXTERNAL_THREAD_API mode.

I would like this and https://reviews.llvm.org/D86599 to be a single review, since I see those two as making the support for an external threading library official.

Sep 8 2020, 7:52 AM · Restricted Project

Sep 1 2020

Nicu abandoned D86599: [libcxx] Add cmake cache file for BUILD_EXTERNAL_THREAD_LIBRARY.

@ldionne I'm closing this revision, as changes have been included in revision https://reviews.llvm.org/D86704 as you requested.

Sep 1 2020, 8:22 AM · Restricted Project
Nicu updated the diff for D86704: [libcxx] Add testing infrastructure for EXTERNAL_THREAD_API mode.

Update commit to include changes from https://reviews.llvm.org/D86599.
Update Summary to reflect this change.

Sep 1 2020, 8:18 AM · Restricted Project
Nicu added a comment to D86598: [libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY.

This seems to have been reverted in

commit a19fd1aab519ccec18654f76a01b0345880c5200
Author: Mikhail Maltsev <mikhail.maltsev@arm.com>
Date:   Thu Aug 27 16:47:18 2020 +0100

    Revert "[libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY"

    This reverts commit 3b71f91558ff8b569199547efe800cb501c3cf94.

    The commit is breaking some build bots.

Has it been committed again with a fix? I don't see it -- what's the status?

Sep 1 2020, 1:04 AM · Restricted Project

Aug 28 2020

Nicu requested review of D86773: [libcxx] Link target `cxx_external_threads` to `cxx-headers` for BUILD_EXTERNAL_THREAD_LIBRARY.
Aug 28 2020, 3:44 AM · Restricted Project

Aug 27 2020

Nicu added a comment to D86598: [libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY.

Sorry about that. I've reverted the change and will investigate.

Thanks. I think the fix is just to remove the inline before _LIBCPP_THREAD_ABI_VISIBILITY, since _LIBCPP_THREAD_ABI_VISIBILITY already contains inline when not in the external threading library mode.

Aug 27 2020, 9:15 AM · Restricted Project
Nicu requested review of D86704: [libcxx] Add testing infrastructure for EXTERNAL_THREAD_API mode.
Aug 27 2020, 5:40 AM · Restricted Project
Nicu updated the diff for D86598: [libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY.

Updated CMakeList.txt to link against 'cxx-headers' rather than just including 'libcxx/include'.
Updated commit's summary to reflect this change.

Aug 27 2020, 2:12 AM · Restricted Project

Aug 26 2020

Nicu updated the diff for D86598: [libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY.

Removed previously added blank line.
Added previously removed blank line.

Aug 26 2020, 6:23 AM · Restricted Project
Nicu requested review of D86599: [libcxx] Add cmake cache file for BUILD_EXTERNAL_THREAD_LIBRARY.
Aug 26 2020, 1:51 AM · Restricted Project
Nicu requested review of D86598: [libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY.
Aug 26 2020, 1:47 AM · Restricted Project

May 21 2020

Nicu created D80372: Fix compile for -DLIBCXX_BUILD_EXTERNAL_THREAD_LIBRARY.
May 21 2020, 3:45 AM · Restricted Project