Page MenuHomePhabricator

[flang] Make `TypeParamInquiry` monomorphic
ClosedPublic

Authored by klausler on Aug 25 2020, 10:16 AM.

Details

Summary

Change the expression representation TypeParamInquiry from being
a class that's templatized on the integer KIND of its result into
a monomorphic representation that results in a SubscriptInteger
that can then be converted.

This is a minor simplification, but it's worth doing because
it is believed to also be a work-around for bugs in the MSVC
compiler with overload resolution that affect the expression
traversal framework.

Diff Detail

Event Timeline

klausler created this revision.Aug 25 2020, 10:16 AM
Herald added a project: Restricted Project. · View Herald Transcript
Meinersbur accepted this revision.EditedAug 31 2020, 1:26 PM

As much as I can say without having a lot of experience with the flang codebase, this looks good to me.

Thanks for the effort!

This revision is now accepted and ready to land.Aug 31 2020, 1:26 PM
This revision was landed with ongoing or failed builds.Aug 31 2020, 3:41 PM
This revision was automatically updated to reflect the committed changes.