[not][test] Fix disable-symbolization.test when 'printenv' is not available

[MaskRay]

Summary

On Windows, 'env' or 'printenv' may not exist.

Also switch back to 'env' which is specified by POSIX.1-2017. 'printenv' is not
standard (I picked it because 'printenv' exists on GnuWin32 but 'env' does not).

[zequanwu]

LGTM.

[MaskRay]

Add a comment

[MaskRay]

Improve description

[MaskRay]

Use -s to suppress 'cmp' output

[thakis]

This breaks check-llvm on windows: http://45.33.8.238/win/22625/step_11.txt

Please take a look and revert for now if it takes a while to fix.

[thakis]

(I'm guessing it was failing under cmd previously and fails in msys/gig bash now?)

[aganea]

I'll fix it.

[MaskRay]

In D86496#2235103, @thakis wrote:

This breaks check-llvm on windows: http://45.33.8.238/win/22625/step_11.txt

Please take a look and revert for now if it takes a while to fix.

In D86496#2235104, @thakis wrote:

(I'm guessing it was failing under cmd previously and fails in msys/gig bash now?)

It worked in a GnuWin32 environment previously but a Chromium (which did not install full GnuWin32) bot was unhappy. So I created this patch. Glad that Alexandre will handle it. Thanks!
Looks like GnuWin32 'env' is not conformant...

[aganea]

In D86496#2235112, @MaskRay wrote:

In D86496#2235103, @thakis wrote:

This breaks check-llvm on windows: http://45.33.8.238/win/22625/step_11.txt

Please take a look and revert for now if it takes a while to fix.

In D86496#2235104, @thakis wrote:

(I'm guessing it was failing under cmd previously and fails in msys/gig bash now?)

It worked in a GnuWin32 environment previously but a Chromium (which did not install full GnuWin32) bot was unhappy. So I created this patch. Glad that Alexandre will handle it. Thanks!
Looks like GnuWin32 'env' is not conformant...

It is not, GnuWin32 comes with CoreUtils 5.3 from 2005 I believe.

[aganea]

@thakis Do you think you can add printenv.exe into https://commondatastorage.googleapis.com/chromium-browser-clang/tools/gnuwin-XX.zip so we can enable the test again on Windows? Please see https://reviews.llvm.org/D86170#inline-799301

[thakis]

In D86496#2235124, @aganea wrote:

@thakis Do you think you can add printenv.exe into https://commondatastorage.googleapis.com/chromium-browser-clang/tools/gnuwin-XX.zip so we can enable the test again on Windows? Please see https://reviews.llvm.org/D86170#inline-799301

We have env as a lit builtin. Can we just use that? What's the not --crash supposed to do here? Why would env crash anyway? I miss context on what this test wants to do.

[aganea]

In D86496#2236188, @thakis wrote:

In D86496#2235124, @aganea wrote:

@thakis Do you think you can add printenv.exe into https://commondatastorage.googleapis.com/chromium-browser-clang/tools/gnuwin-XX.zip so we can enable the test again on Windows? Please see https://reviews.llvm.org/D86170#inline-799301

We have env as a lit builtin. Can we just use that? What's the not --crash supposed to do here? Why would env crash anyway? I miss context on what this test wants to do.

I was under the false impression yesterday that the local env.exe (found in GnuWin32) wouldn't print the environment block, but it does. It seems the problem lies in how the commands are interpreted by lit. On Windows, with this test, we reach this: https://github.com/llvm/llvm-project/blob/master/llvm/utils/lit/lit/TestRunner.py#L645 - but on not Linux?

llvm/test/tools/not/disable-symbolization.test

-# RUN: not --crash printenv > %t || true
-# RUN: FileCheck %s < %t
+## 'env' may not exist on Windows. %t will be empty.
+# RUN: not --crash env > %t || true
+# RUN: cmp %t /dev/null || FileCheck %s < %t
 
 # CHECK-DAG: LLVM_DISABLE_CRASH_REPORT=1
 # CHECK-DAG: LLVM_DISABLE_SYMBOLIZATION=1