This is an archive of the discontinued LLVM Phabricator instance.

[flang] Don't attempt to compute element size if no DynamicType
ClosedPublic

Authored by tskeith on Aug 24 2020, 12:31 PM.

Details

Summary

If an error has occurred a symbol may have a DeclTypeSpec but no
valid DynamicType. There is no need to compute the size of erroneous
symbols.

Also, we only need to process object entities and procedure entities.
All other kinds of symbols can be skipped.

This fixes another problem revealed by https://bugs.llvm.org/show_bug.cgi?id=47265

Diff Detail

Event Timeline

tskeith created this revision.Aug 24 2020, 12:31 PM
Herald added a project: Restricted Project. · View Herald Transcript
tskeith requested review of this revision.Aug 24 2020, 12:31 PM
klausler accepted this revision.Aug 24 2020, 1:20 PM
This revision is now accepted and ready to land.Aug 24 2020, 1:20 PM