Page MenuHomePhabricator

Use the named accessor methods in predicate substitutions.
Needs ReviewPublic

Authored by awpr on Aug 21 2020, 4:10 PM.

Details

Reviewers
jpienaar
Summary

Previously, using these substitutions for optional operands/results
would dereference a potentially-past-the-end iterator. Now, an absent
optional operand/result will correspond to a null Operand/Value, and
variadics will still correspond to ranges.

Diff Detail

Event Timeline

awpr created this revision.Aug 21 2020, 4:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 21 2020, 4:10 PM
awpr requested review of this revision.Aug 21 2020, 4:10 PM

Nice, thanks. Could you add a test with an optional attr that would have failed here before?