This is an archive of the discontinued LLVM Phabricator instance.

Differential D86284

[clangd] Remove useless stderr logging.
ClosedPublic

Authored by adamcz on Aug 20 2020, 5:49 AM.

Details

Reviewers
None
Commits
rG707138d67786: [clangd] Remove useless stderr logging.
Summary

This was accidentally added in 53b9199a5cdba8a6e294e1fb183f308ec558db22

Diff Detail

Event Timeline

adamcz created this revision.Aug 20 2020, 5:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 20 2020, 5:49 AM
Herald added subscribers: cfe-commits, usaxena95, kadircet and 2 others. · View Herald Transcript
adamcz requested review of this revision.Aug 20 2020, 5:49 AM
Herald added subscribers: MaskRay, ilya-biryukov. · View Herald TranscriptAug 20 2020, 5:49 AM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 20 2020, 5:52 AM
This revision was landed with ongoing or failed builds.
Closed by commit rG707138d67786: [clangd] Remove useless stderr logging. (authored by adamcz). · Explain Why
This revision was automatically updated to reflect the committed changes.
adamcz added a commit: rG707138d67786: [clangd] Remove useless stderr logging..
Harbormaster completed remote builds in B69020: Diff 286795.Aug 20 2020, 7:04 AM

Revision Contents

PathSize
clang-tools-extra/
clangd/
unittests/
2 lines

Diff 286796

clang-tools-extra/clangd/unittests/TestTU.cpp

Show First 20 Lines • Show All 68 Lines • ▼ Show 20 LinesParseInputs TestTU::inputs(MockFS &FS) const {
return Inputs; return Inputs;
} }
void initializeModuleCache(CompilerInvocation &CI) { void initializeModuleCache(CompilerInvocation &CI) {
llvm::SmallString<128> ModuleCachePath; llvm::SmallString<128> ModuleCachePath;
ASSERT_FALSE( ASSERT_FALSE(
llvm::sys::fs::createUniqueDirectory("module-cache", ModuleCachePath)); llvm::sys::fs::createUniqueDirectory("module-cache", ModuleCachePath));
CI.getHeaderSearchOpts().ModuleCachePath = ModuleCachePath.c_str(); CI.getHeaderSearchOpts().ModuleCachePath = ModuleCachePath.c_str();
llvm::errs() << "MC: " << ModuleCachePath << "\n";
llvm::errs().flush();
} }
void deleteModuleCache(const std::string ModuleCachePath) { void deleteModuleCache(const std::string ModuleCachePath) {
if (!ModuleCachePath.empty()) { if (!ModuleCachePath.empty()) {
ASSERT_FALSE(llvm::sys::fs::remove_directories(ModuleCachePath)); ASSERT_FALSE(llvm::sys::fs::remove_directories(ModuleCachePath));
} }
} }
▲ Show 20 Lines • Show All 157 Lines • Show Last 20 Lines