Fix swig scripts install target name

[aadsm]

Summary

LLVM install component targets needs to be in the form of: install-{target}[-stripped]

I tested with:

cmake ... -DLLVM_ENABLE_PROJECTS="clang;lldb" -DLLVM_DISTRIBUTION_COMPONENTS="lldb;liblldb;finish_swig_python_scripts" ...
DESTDIR=... ninja install-distribution

@JDevlieghere finish_swig_python_scripts is a really weird name for a distribution component, any reason it has to be this way? (this was changed here from lldb-python-scripts https://github.com/llvm/llvm-project/commit/9a3dbc972322413045bb5672b0fd3ba8c216c987)

[JDevlieghere]

No reason other than consistency by always appending to the given target. I didn't think of the requirement for the install-prefix. LGTM!

[aadsm]

@JDevlieghere thanks for the quick review, but on the name I mean the actual finish_swig_python_scripts, this sounds like a step name and not a component distributed by llvm like liblldb ot lldb-server. That was the reason at the time I named it lldb-python-scripts because it was very clear what was being installed.
Would you be fine with me changing swig_scripts_target back to lldb-python-scripts?

[JDevlieghere]

In D86235#2227052, @aadsm wrote:

@JDevlieghere thanks for the quick review, but on the name I mean the actual finish_swig_python_scripts, this sounds like a step name and not a component distributed by llvm like liblldb ot lldb-server. That was the reason at the time I named it lldb-python-scripts because it was very clear what was being installed.
Would you be fine with me changing swig_scripts_target back to lldb-python-scripts?

No objections at all. IIUC that would mean changing the first argument in CMakeLists.txt:89 to:

finish_swig_python("lldb-python" "${lldb_python_bindings_dir}" "${lldb_python_target_dir}")

and then in CMakeLists.txt:166 something like

set(swig_scripts_target "${swig_target}-scripts")
set(swig_scripts_install_target "install-${swig_scripts_target}")

Sounds good to me, I didn't know anybody as explicitly specifying them anywhere, I wouldn't have broken that if I had known. My apologies.

[aadsm]

Updated to use more friendly component name lldb-python-scripts name instead of finish_swig_python_scripts

lldb/bindings/python/CMakeLists.txt

if(LLDB_BUILD_FRAMEWORK)
     set(LLDB_PYTHON_INSTALL_PATH ${LLDB_FRAMEWORK_INSTALL_DIR}/LLDB.framework/Resources/Python)
   else()
     set(LLDB_PYTHON_INSTALL_PATH ${LLDB_PYTHON_RELATIVE_PATH})
   endif()
   if (NOT CMAKE_CFG_INTDIR STREQUAL  ".")
     string(REPLACE ${CMAKE_CFG_INTDIR} "\$\{CMAKE_INSTALL_CONFIG_NAME\}" LLDB_PYTHON_INSTALL_PATH ${LLDB_PYTHON_INSTALL_PATH})
     string(REPLACE ${CMAKE_CFG_INTDIR} "\$\{CMAKE_INSTALL_CONFIG_NAME\}" lldb_python_target_dir ${lldb_python_target_dir})
   endif()
-  set(swig_scripts_target "${swig_target}_scripts")
-  set(swig_scripts_install_target "${swig_target}_scripts_install")
-  add_custom_target(${swig_scripts_target})
-  add_dependencies(${swig_scripts_target} ${swig_target})
+  set(python_scripts_target "lldb-python-scripts")
+  set(python_scripts_install_target "install-${python_scripts_target}")
+  add_custom_target(${python_scripts_target})
+  add_dependencies(${python_scripts_target} ${swig_target})
   install(DIRECTORY ${lldb_python_target_dir}/../
           DESTINATION ${LLDB_PYTHON_INSTALL_PATH}
-          COMPONENT ${swig_scripts_target})
+          COMPONENT ${python_scripts_target})
   if (NOT LLVM_ENABLE_IDE)
-    add_llvm_install_targets(${swig_scripts_install_target}
-                             COMPONENT ${swig_scripts_target}
-                             DEPENDS ${swig_scripts_target})
+    add_llvm_install_targets(${python_scripts_install_target}
+                             COMPONENT ${python_scripts_target}
+                             DEPENDS ${python_scripts_target})
   endif()
 
   # Add a Post-Build Event to copy the custom Python DLL to the lldb binaries dir so that Windows can find it when launching
   # lldb.exe or any other executables that were linked with liblldb.
   if (WIN32 AND NOT "${PYTHON_DLL}" STREQUAL "")
     # When using the Visual Studio CMake generator the lldb binaries end up in Release/bin, Debug/bin etc.
     file(TO_NATIVE_PATH "${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin" LLDB_BIN_DIR)
     file(TO_NATIVE_PATH "${PYTHON_DLL}" PYTHON_DLL_NATIVE_PATH)
     add_custom_command(
       TARGET ${swig_target}
       POST_BUILD
       COMMAND ${CMAKE_COMMAND} -E copy ${PYTHON_DLL_NATIVE_PATH} ${LLDB_BIN_DIR} VERBATIM
       COMMENT "Copying Python DLL to LLDB binaries directory.")
   endif()
 endfunction()