This is an archive of the discontinued LLVM Phabricator instance.

Differential D86136

[ELF] Hide target specific methods as private
ClosedPublic

Authored by rochauha on Aug 18 2020, 5:46 AM.

Details

Reviewers
scott.linder
jhenderson
Commits
rG7b777ee73077: [ELF] Hide target specific methods as private

Diff Detail

Unit TestsFailed

TimeTest
90 mswindows > LLVM.DebugInfo/X86::addr-tu-to-non-tu.ll

Event Timeline

rochauha created this revision.Aug 18 2020, 5:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 18 2020, 5:46 AM
Herald added subscribers: llvm-commits, s.egerton, simoncook. · View Herald Transcript
rochauha requested review of this revision.Aug 18 2020, 5:46 AM
rochauha added a parent revision: D84519: [llvm-objdump][AMDGPU] Detect CPU string.Aug 18 2020, 5:47 AM
jhenderson accepted this revision.Aug 18 2020, 5:54 AM

LGTM, thanks!

This revision is now accepted and ready to land.Aug 18 2020, 5:54 AM
This revision was landed with ongoing or failed builds.Aug 18 2020, 5:57 AM
Closed by commit rG7b777ee73077: [ELF] Hide target specific methods as private (authored by rochauha). · Explain Why
This revision was automatically updated to reflect the committed changes.
rochauha added a commit: rG7b777ee73077: [ELF] Hide target specific methods as private.
Harbormaster completed remote builds in B68741: Diff 286260.Aug 18 2020, 6:19 AM

Revision Contents

PathSize
llvm/
include/
llvm/
Object/
14 lines

Diff 286260

llvm/include/llvm/Object/ELFObjectFile.h

Show First 20 Lines • Show All 45 Lines • ▼ Show 20 Lines
class elf_symbol_iterator; class elf_symbol_iterator;
class ELFObjectFileBase : public ObjectFile { class ELFObjectFileBase : public ObjectFile {
friend class ELFRelocationRef; friend class ELFRelocationRef;
friend class ELFSectionRef; friend class ELFSectionRef;
friend class ELFSymbolRef; friend class ELFSymbolRef;
SubtargetFeatures getMIPSFeatures() const;
SubtargetFeatures getARMFeatures() const;
SubtargetFeatures getRISCVFeatures() const;
StringRef getAMDGPUCPUName() const;
protected: protected:
ELFObjectFileBase(unsigned int Type, MemoryBufferRef Source); ELFObjectFileBase(unsigned int Type, MemoryBufferRef Source);
virtual uint64_t getSymbolSize(DataRefImpl Symb) const = 0; virtual uint64_t getSymbolSize(DataRefImpl Symb) const = 0;
virtual uint8_t getSymbolBinding(DataRefImpl Symb) const = 0; virtual uint8_t getSymbolBinding(DataRefImpl Symb) const = 0;
virtual uint8_t getSymbolOther(DataRefImpl Symb) const = 0; virtual uint8_t getSymbolOther(DataRefImpl Symb) const = 0;
virtual uint8_t getSymbolELFType(DataRefImpl Symb) const = 0; virtual uint8_t getSymbolELFType(DataRefImpl Symb) const = 0;
Show All 13 Linespublic:
virtual unsigned getPlatformFlags() const = 0; virtual unsigned getPlatformFlags() const = 0;
elf_symbol_iterator_range symbols() const; elf_symbol_iterator_range symbols() const;
static bool classof(const Binary *v) { return v->isELF(); } static bool classof(const Binary *v) { return v->isELF(); }
SubtargetFeatures getFeatures() const override; SubtargetFeatures getFeatures() const override;
SubtargetFeatures getMIPSFeatures() const;
SubtargetFeatures getARMFeatures() const;
SubtargetFeatures getRISCVFeatures() const;
Optional<StringRef> tryGetCPUName() const override; Optional<StringRef> tryGetCPUName() const override;
StringRef getAMDGPUCPUName() const;
void setARMSubArch(Triple &TheTriple) const override; void setARMSubArch(Triple &TheTriple) const override;
virtual uint16_t getEType() const = 0; virtual uint16_t getEType() const = 0;
virtual uint16_t getEMachine() const = 0; virtual uint16_t getEMachine() const = 0;
std::vector<std::pair<Optional<DataRefImpl>, uint64_t>> std::vector<std::pair<Optional<DataRefImpl>, uint64_t>>
getPltAddresses() const; getPltAddresses() const;
▲ Show 20 Lines • Show All 1,152 Lines • Show Last 20 Lines