Page MenuHomePhabricator

[clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive
ClosedPublic

Authored by CarolineConcatto on Aug 18 2020, 3:46 AM.

Details

Summary

If a folder's name, where the test fortran.f95 is running, has cc1 the test
fails because of CHECK-ASM-NOT: cc1.
The solution used in this patch is to add quotation mark around cc1 and cc1as
because the driver returns these flags with quotation marks ("")

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptAug 18 2020, 3:46 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
CarolineConcatto requested review of this revision.Aug 18 2020, 3:46 AM
DavidTruby requested changes to this revision.Aug 18 2020, 4:10 AM

On my clang line, when compiling a C file, this appears as "-cc1" not "cc1". I don't see a cc1as so I can't check that one but I assume it will be the same.

This revision now requires changes to proceed.Aug 18 2020, 4:10 AM
This revision is now accepted and ready to land.Aug 18 2020, 6:16 AM
echristo accepted this revision.Aug 18 2020, 12:56 PM
This revision was landed with ongoing or failed builds.Aug 19 2020, 9:55 AM
This revision was automatically updated to reflect the committed changes.