This is an archive of the discontinued LLVM Phabricator instance.

[clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive
ClosedPublic

Authored by CarolineConcatto on Aug 18 2020, 3:46 AM.

Download Raw Diff

Details

Reviewers

DavidTruby
peterwaller-arm
echristo

Commits

rG33c554d8444a: [clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive

Summary

If a folder's name, where the test fortran.f95 is running, has cc1 the test
fails because of CHECK-ASM-NOT: cc1.
The solution used in this patch is to add quotation mark around cc1 and cc1as
because the driver returns these flags with quotation marks ("")

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

CarolineConcatto created this revision.Aug 18 2020, 3:46 AM

Herald added a project: Restricted Project. · View Herald TranscriptAug 18 2020, 3:46 AM

Herald added a subscriber: cfe-commits. · View Herald Transcript

CarolineConcatto requested review of this revision.Aug 18 2020, 3:46 AM

CarolineConcatto added reviewers: DavidTruby, kiranchandramohan.Aug 18 2020, 3:46 AM

CarolineConcatto added a reviewer: peterwaller-arm.Aug 18 2020, 3:50 AM

CarolineConcatto removed a reviewer: kiranchandramohan.

CarolineConcatto added a reviewer: echristo.Aug 18 2020, 3:57 AM

On my clang line, when compiling a C file, this appears as "-cc1" not "cc1". I don't see a cc1as so I can't check that one but I assume it will be the same.

This revision now requires changes to proceed.Aug 18 2020, 4:10 AM

Harbormaster completed remote builds in B68729: Diff 286240.Aug 18 2020, 4:30 AM

Missing a -

Harbormaster completed remote builds in B68737: Diff 286257.Aug 18 2020, 5:59 AM

LGTM

This revision is now accepted and ready to land.Aug 18 2020, 6:16 AM

echristo accepted this revision.Aug 18 2020, 12:56 PM

This revision was landed with ongoing or failed builds.Aug 19 2020, 9:55 AM

Closed by commit rG33c554d8444a: [clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive (authored by CarolineConcatto). · Explain Why

This revision was automatically updated to reflect the committed changes.

CarolineConcatto added a commit: rG33c554d8444a: [clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive.

Revision Contents

Path

Size

clang/

test/

Driver/

fortran.f95

4 lines

Diff 286594

clang/test/Driver/fortran.f95

	! Check that the clang driver can invoke gcc to compile Fortran when in			! Check that the clang driver can invoke gcc to compile Fortran when in
	! --driver-mode=clang. This is legacy behaviour - see also --driver-mode=flang.			! --driver-mode=clang. This is legacy behaviour - see also --driver-mode=flang.

	! RUN: %clang -target x86_64-unknown-linux-gnu -integrated-as -c %s -### 2>&1 \			! RUN: %clang -target x86_64-unknown-linux-gnu -integrated-as -c %s -### 2>&1 \
	! RUN: \| FileCheck --check-prefix=CHECK-OBJECT %s			! RUN: \| FileCheck --check-prefix=CHECK-OBJECT %s
	! CHECK-OBJECT: gcc			! CHECK-OBJECT: gcc
	! CHECK-OBJECT: "-c"			! CHECK-OBJECT: "-c"
	! CHECK-OBJECT: "-x" "f95"			! CHECK-OBJECT: "-x" "f95"
	! CHECK-OBJECT-NOT: cc1as			! CHECK-OBJECT-NOT: "-cc1as"

	! RUN: %clang -target x86_64-unknown-linux-gnu -integrated-as -S %s -### 2>&1 \			! RUN: %clang -target x86_64-unknown-linux-gnu -integrated-as -S %s -### 2>&1 \
	! RUN: \| FileCheck --check-prefix=CHECK-ASM %s			! RUN: \| FileCheck --check-prefix=CHECK-ASM %s
	! CHECK-ASM: gcc			! CHECK-ASM: gcc
	! CHECK-ASM: "-S"			! CHECK-ASM: "-S"
	! CHECK-ASM: "-x" "f95"			! CHECK-ASM: "-x" "f95"
	! CHECK-ASM-NOT: cc1			! CHECK-ASM-NOT: "-cc1"

	! RUN: %clang -Wall -target x86_64-unknown-linux-gnu -integrated-as %s -o %t -### 2>&1 \| FileCheck --check-prefix=CHECK-WARN %s			! RUN: %clang -Wall -target x86_64-unknown-linux-gnu -integrated-as %s -o %t -### 2>&1 \| FileCheck --check-prefix=CHECK-WARN %s
	! CHECK-WARN: gcc			! CHECK-WARN: gcc
	! CHECK-WARN-NOT: "-Wall"			! CHECK-WARN-NOT: "-Wall"
	! CHECK-WARN: ld			! CHECK-WARN: ld
	! CHECK-WARN-NOT: "-Wall"			! CHECK-WARN-NOT: "-Wall"