Page MenuHomePhabricator

[libomptarget][NFC] Sort list of plugins in chronological order
ClosedPublic

Authored by grokos on Aug 17 2020, 8:29 AM.

Details

Summary

At the Aug 12 2020 telecon we agreed to reorder the list of plugins chronologically.

Libomptarget was checked into the trunk when the generic-elf-64 and CUDA plugins had already been developed, so there is no evidence which plugin was developed first (see https://reviews.llvm.org/rG2467df6e4f04e3d0e8e78d662473ba1b87c0a885). Looking into IBM's clang-ykt branch doesn't help either - the oldest commit already contains both plugins. Because I was working for IBM when we started libomptarget development I can more or less remember what we did first and what we did last but this isn't documented anywhere.

In the very early days we developed the generic-elf-64 plugin as a means of having some prototype to test libomptarget with. Because development was done on PPC machines I assume that the ppc build of the generic-elf-64 plugin should come first. The x86 variant follows. The CUDA plugin was developed slightly later.

The rest of the plugins were enabled after libomptarget was upstreamed and the order can be found by browsing the commits. First we had support for aarch64 via the generic-elf-64 plugin (https://reviews.llvm.org/rG1e254c5295502526362efa1757359fdfaf92495d), then came support for SX-Aurora (https://reviews.llvm.org/rG6b9e43c67e0b109881db2524ec5207c4a888e7f7) and finally amdgpu (https://reviews.llvm.org/rGd0b312955f12beba5b03c8a524a8456cb4174bd7).

Diff Detail

Event Timeline

grokos created this revision.Aug 17 2020, 8:29 AM
grokos requested review of this revision.Aug 17 2020, 8:29 AM
JonChesterfield accepted this revision.Aug 17 2020, 8:30 AM

Well volunteered, thank you very much!

This revision is now accepted and ready to land.Aug 17 2020, 8:30 AM
This revision was landed with ongoing or failed builds.Aug 17 2020, 8:36 AM
This revision was automatically updated to reflect the committed changes.