This is an archive of the discontinued LLVM Phabricator instance.

Differential D85957

[mlir] Make mlir_check_link_libraries() work with interface libraries
ClosedPublic

Authored by marbre on Aug 13 2020, 11:28 PM.

Details

Reviewers
stephenneuendorffer
Commits
rG324ae458df7e: [mlir] Make mlir_check_link_libraries() work with interface libraries
Summary

This changes mlir_check_link_libraries() to work with interface libraries. These don't have the LINK_LIBRARIES property.

Diff Detail

Event Timeline

marbre created this revision.Aug 13 2020, 11:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 13 2020, 11:28 PM
Herald added subscribers: msifontes, jurahul, Kayjukh and 13 others. · View Herald Transcript
marbre requested review of this revision.Aug 13 2020, 11:28 PM
Herald added a subscriber: nicolasvasilache. · View Herald TranscriptAug 13 2020, 11:28 PM
Harbormaster completed remote builds in B68376: Diff 285560.Aug 13 2020, 11:28 PM
stephenneuendorffer accepted this revision.Aug 14 2020, 10:51 AM
This revision is now accepted and ready to land.Aug 14 2020, 10:51 AM
This revision was landed with ongoing or failed builds.Aug 14 2020, 11:39 AM
Closed by commit rG324ae458df7e: [mlir] Make mlir_check_link_libraries() work with interface libraries (authored by marbre, committed by stephenneuendorffer). · Explain Why
This revision was automatically updated to reflect the committed changes.
stephenneuendorffer added a commit: rG324ae458df7e: [mlir] Make mlir_check_link_libraries() work with interface libraries.

Revision Contents

PathSize
mlir/
cmake/
modules/
7 lines

Diff 285716

mlir/cmake/modules/AddMLIR.cmake

Show First 20 Lines • Show All 178 Lines • ▼ Show 20 Lines
function(add_mlir_translation_library name) function(add_mlir_translation_library name)
set_property(GLOBAL APPEND PROPERTY MLIR_TRANSLATION_LIBS ${name}) set_property(GLOBAL APPEND PROPERTY MLIR_TRANSLATION_LIBS ${name})
add_mlir_library(${ARGV} DEPENDS mlir-headers) add_mlir_library(${ARGV} DEPENDS mlir-headers)
endfunction(add_mlir_translation_library) endfunction(add_mlir_translation_library)
# Verification tools to aid debugging. # Verification tools to aid debugging.
function(mlir_check_link_libraries name) function(mlir_check_link_libraries name)
if(TARGET ${name}) if(TARGET ${name})
get_target_property(type ${name} TYPE)
if (${type} STREQUAL "INTERFACE_LIBRARY")
get_target_property(libs ${name} INTERFACE_LINK_LIBRARIES)
else()
get_target_property(libs ${name} LINK_LIBRARIES) get_target_property(libs ${name} LINK_LIBRARIES)
endif()
# message("${name} libs are: ${libs}") # message("${name} libs are: ${libs}")
set(linking_llvm 0) set(linking_llvm 0)
foreach(lib ${libs}) foreach(lib ${libs})
if(lib) if(lib)
if(${lib} MATCHES "^LLVM$") if(${lib} MATCHES "^LLVM$")
set(linking_llvm 1) set(linking_llvm 1)
endif() endif()
if((${lib} MATCHES "^LLVM.+") AND ${linking_llvm}) if((${lib} MATCHES "^LLVM.+") AND ${linking_llvm})
Show All 21 Lines